Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): add select-comobobox reusable component #94

Merged
merged 6 commits into from May 6, 2022

Conversation

richbachman
Copy link
Contributor

@richbachman richbachman commented May 5, 2022

Description of the change

  • Makes select combobox more reusable
  • Maintains the styled exports

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@changeset-bot
Copy link

changeset-bot bot commented May 5, 2022

🦋 Changeset detected

Latest commit: f258246

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@trueplan/forecast-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@richbachman richbachman changed the title feat: add select-comobobox reusable component feat(components): add select-comobobox reusable component May 5, 2022
@trueplan-automaton trueplan-automaton requested review from a team and RohitRajendran and removed request for a team May 5, 2022 20:47
Copy link
Contributor

@jnlsn jnlsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@richbachman richbachman merged commit 931cd84 into main May 6, 2022
@richbachman richbachman deleted the feat/refine-select-combobox branch May 6, 2022 16:52
@github-actions github-actions bot mentioned this pull request May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants