[INS-320] Cloudinary detector#4747
Merged
MuneebUllahKhan222 merged 16 commits intoApr 30, 2026
Merged
Conversation
MuneebUllahKhan222
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
amanfcp
approved these changes
Feb 18, 2026
amanfcp
left a comment
amanfcp
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just shared a concern which could lead to false negatives.
rosecodym
approved these changes
Feb 19, 2026
rosecodym
left a comment
rosecodym
left a comment
Contributor
There was a problem hiding this comment.
🤠 for a new detector. I've created a backlog ticket to separate this codeownership.
shahzadhaider1
approved these changes
Feb 26, 2026
shahzadhaider1
left a comment
shahzadhaider1
left a comment
Contributor
There was a problem hiding this comment.
please resolve the conflicts
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit edbff82. Configure here.
MuneebUllahKhan222
added a commit
that referenced
this pull request
May 29, 2026
* added cloudinary detector * resolved linter issue * improved regex * added dector to defaults.go * resolved comments * Regen protos, Updated desc and ignore secret part in test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds cloudinary detector. It detects cloudinary creds like cloud name, api key and api secret and verifies them.
Checklist:
make test-community)?make lintthis requires golangci-lint)?Note
Medium Risk
Adds a new detector that performs outbound HTTP verification against Cloudinary’s API and constructs results by combining independently matched secret parts, which could affect scan performance and verification behavior if patterns over-match.
Overview
Adds a new Cloudinary detector that extracts
cloud_name,api_key, andapi_secret(includingcloudinary://...URL-style creds), emits a combinedRawV2triple, and optionally verifies credentials via a Basic Auth call to Cloudinary’susageendpoint.Registers the detector in the default detector list and extends the
DetectorTypeenum/proto to includeCloudinary, with unit + integration tests and a benchmark covering matching and verification outcomes.Reviewed by Cursor Bugbot for commit 2a7c9f4. Bugbot is set up for automated code reviews on this repo. Configure here.