[INS-403] Support Custom endpoint config in hashicorpvaultauth Detector#4825
Merged
MuneebUllahKhan222 merged 7 commits intoApr 13, 2026
Merged
Conversation
rosecodym
approved these changes
Mar 19, 2026
shahzadhaider1
approved these changes
Mar 19, 2026
themavik
reviewed
Mar 23, 2026
themavik
left a comment
themavik
left a comment
There was a problem hiding this comment.
Embedding EndpointSetter/DefaultMultiPartCredentialProvider and dropping the hard requirement on an extracted vault URL matches the custom-endpoint use case. this could break if Endpoints(empty) does not fall back to the same default targets the old code implied — worth one integration run with role+secret only and no URL in the blob.
Removed URL validation checks from integration test.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit fe49c7f. Configure here.
MuneebUllahKhan222
added a commit
that referenced
this pull request
May 29, 2026
…or (#4825) * Added custom verification endpoint config to vault auth detector * fixed deduplication bugbot comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR enabled custom endpoint configuration for the existing hashicorpvaultauth detector.
It enables custom endpoint configuration by making the detector comply to
detectors.EndpointCustomizerinterface and updating to default client todetectors.DetectorHttpClientWithNoLocalAddressesto avoid potential security risks like ssrf attacks.This PR also updates the existing test to make sure that the test work fine with the new changes and also introduces a new integration test to emulate custom endpoint configuration.
Checklist:
make test-community)?make lintthis requires golangci-lint)?Note
Medium Risk
Changes the HashiCorp Vault auth detector’s verification targeting by introducing configurable/found endpoint selection and switching to a no-local-address HTTP client, which could impact verification behavior and network access patterns.
Overview
Adds custom endpoint configuration to the
hashicorpvaultauthdetector by embeddingdetectors.EndpointSetterand implementingdetectors.EndpointCustomizer, so verification can run against configured endpoints and/or endpoints discovered in scanned data.Updates verification to use
detectors.DetectorHttpClientWithNoLocalAddressesby default (reducing SSRF risk), loosens result generation to no longer require a Vault URL in input (endpoints now come from configuration and/or found URLs), and adjusts unit/integration tests accordingly, including a new integration test coveringSetConfiguredEndpoints.Reviewed by Cursor Bugbot for commit ae13d6a. Bugbot is set up for automated code reviews on this repo. Configure here.