Deprecate SquareUp Detector#4855
Merged
Merged
Conversation
shahzadhaider1
approved these changes
Apr 1, 2026
camgunz
approved these changes
Apr 10, 2026
2 tasks
MuneebUllahKhan222
pushed a commit
that referenced
this pull request
May 29, 2026
* deprecated the squareup detector * regenerated detectors.pb.go after merging latest main changes --------- Co-authored-by: Charlie Gunyon <charlie.gunyon@trufflesec.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR deprecates the SquareUp detector.
The verification endpoint (
GET /oauth2/authorize) returns inconsistent status codes regardless of whether the secret is valid, causing secrets to flip between "live" and "rotated" repeatedly.Also, the
sq0idp-prefix identifies a SquareUp OAuth Client ID, which is a public identifier, not a secret. The actual secret is being handled by the SquareApp detector.Changes:
[deprecated = true]indetectors.protoand regenerateddetectors.pb.gosquareup.Scannerregistration fromdefaults.gopkg/detectors/squareup/Checklist:
make test-community)?make lintthis requires golangci-lint)?Note
Low Risk
Low risk: this removes a detector and its tests from the default detector set, mainly impacting detection coverage and any downstream code relying on
Squareupresults.Overview
Deprecates and effectively disables the
Squareupdetector. TheSquareupenum value inproto/detectors.protois now marked deprecated (with regenerateddetectors.pb.goreflecting this).The
squareupdetector implementation and its unit/integration tests underpkg/detectors/squareup/are deleted, andsquareup.Scanner{}is removed frompkg/engine/defaults/defaults.goso it no longer runs by default.Written by Cursor Bugbot for commit 6542ab1. This will update automatically on new commits. Configure here.