Upgrade golangci-lint in CI runner and Makefile#4861
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
…25 toolchain fetch while restricting make lint command to same version as CI
…curity/trufflehog into amaan/upgrade-golangci-lint-v2
…an/upgrade-golangci-lint-v2
…curity/trufflehog into amaan/upgrade-golangci-lint-v2
- extract exact semantic version - check system path first before GOPATH/bin to avoid potential duplication
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4ebd548. Configure here.
|
On second thought, we could also use a Docker image in the Makefile 🤔 |
It's a good suggestion. Docker makes more sense for protos since proto generation has dependencies (protoc, plugins, etc.) that are painful to install locally. Since linting is a single Go binary, I'd suggest we stick with the shell script with version pinning here. |
Made-with: Cursor
* upgrade golangci-lint * upgrade golangci-lint to v2 via go tool and align local/CI lint configuration * pinned version script for local/CI parity * resolve golangci-lint binary via GOPATH to avoid PATH shadowing * use golangci-lint-action@v7 in CI with prebuilt binary to avoid Go 1.25 toolchain fetch while restricting make lint command to same version as CI * incorporate feedback - extract exact semantic version - check system path first before GOPATH/bin to avoid potential duplication * Add cross-reference comments for lint version/args sync Made-with: Cursor --------- Co-authored-by: Bryan Beverly <bryan.beverly@trufflesec.com>
3 participants
Description:
Upgrades golangci-lint from
v1tov2, pinned atv2.11.4. CI usesgolangci-lint-action@v7with a prebuilt binary (no Go 1.25 toolchain fetch). Local make lint now callsscripts/lint.sh, which auto-installs the exact pinned version via curl, eliminating system-installed version mismatches.The deprecated
--out-formatflag is removed (colored output is default in v2).errcheckandstaticcheckare temporarily disabled as v2's stricter defaults surface ~100 pre-existing issues, to be addressed in a follow-up.Checklist:
make test-community)?make lintthis requires golangci-lint)?Note
Medium Risk
Moderate risk because it changes the linting gate (upgrading to golangci-lint v2 and temporarily disabling
errcheck/staticcheck), which could allow issues to slip through even though it doesn’t affect runtime behavior.Overview
Upgrades CI linting to
golangci-lint-action@v7and pinsgolangci-linttov2.11.4, aligning CI flags with local usage.Replaces
make lint’s directgolangci-lint runinvocation with a newscripts/lint.shthat ensures the exact pinned linter version is installed/used and runs with updated args (including temporarily disablingerrcheckandstaticcheck).Reviewed by Cursor Bugbot for commit 9593f53. Bugbot is set up for automated code reviews on this repo. Configure here.