Skip to content

Rename AnalysisInfo field to SecretParts on detectors.Result#4911

Merged
mcastorina merged 1 commit into
mainfrom
secret-parts-rename-draft
Apr 23, 2026
Merged

Rename AnalysisInfo field to SecretParts on detectors.Result#4911
mcastorina merged 1 commit into
mainfrom
secret-parts-rename-draft

Conversation

@mcastorina

@mcastorina mcastorina commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

Description:

Mechanical rename of the detectors.Result.AnalysisInfo field to SecretParts to prepare for its replacement for Raw.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

Note

Medium Risk
Broad mechanical rename of a core struct field used across many detectors and tests; risk is mainly compile/runtime breakage for downstream code expecting AnalysisInfo and any analyzers/output paths not fully updated.

Overview
Renames the detectors.Result field used to pass analyzer inputs from AnalysisInfo to SecretParts, updating the struct comment to reflect multi-part credential components.

Updates a large set of detectors to populate SecretParts (instead of AnalysisInfo) on verified results, and adjusts integration/unit tests to ignore/clear SecretParts accordingly.

Tweaks plain-text output (pkg/output/plain.go) to show the analysis hint based on SecretParts being present for verified results.

Reviewed by Cursor Bugbot for commit 7185681. Bugbot is set up for automated code reviews on this repo. Configure here.

Mechanical rename of the detectors.Result.AnalysisInfo field to
SecretParts to prepare for its replacement for Raw.
@mcastorina mcastorina merged commit 1529239 into main Apr 23, 2026
15 checks passed
@mcastorina mcastorina deleted the secret-parts-rename-draft branch April 23, 2026 17:52
MuneebUllahKhan222 pushed a commit that referenced this pull request May 29, 2026
Mechanical rename of the detectors.Result.AnalysisInfo field to
SecretParts to prepare for its replacement for Raw.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants