Skip to content

log non-critical chunk errors at V(2).Info instead of Error#4928

Merged
rosecodym merged 1 commit into
mainfrom
hackathon/handlers-428-severity
Apr 29, 2026
Merged

log non-critical chunk errors at V(2).Info instead of Error#4928
rosecodym merged 1 commit into
mainfrom
hackathon/handlers-428-severity

Conversation

@johnelliott

@johnelliott johnelliott commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Non-fatal scanning errors aren't really "errors" - they're consequences of the vicissitudes of scanning a ton of data. They're actionable if you're looking for them but if you're not they're extremely noisy. This PR downgrades them to only show up when you look for them.

Test plan

  • CI passes (existing handler tests cover the success/fatal paths; non-fatal logging path is purely observational)

@johnelliott johnelliott marked this pull request as ready for review April 29, 2026 15:30
@johnelliott johnelliott requested a review from a team April 29, 2026 15:30
@johnelliott johnelliott requested a review from a team as a code owner April 29, 2026 15:30
@johnelliott johnelliott requested a review from a team April 29, 2026 15:30
@rosecodym rosecodym merged commit cf31c26 into main Apr 29, 2026
16 checks passed
@rosecodym rosecodym deleted the hackathon/handlers-428-severity branch April 29, 2026 17:03
MuneebUllahKhan222 pushed a commit that referenced this pull request May 29, 2026
Non-fatal scanning errors aren't really "errors" - they're consequences of the vicissitudes of scanning a ton of data. They're actionable if you're looking for them but if you're not they're extremely noisy. This commit downgrades them to only show up when you look for them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants