Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Refactor/use observable instead of Subject for fromSubscribe in new-block-stream #112
Thanks to @jklepatch for bringing this issue up with me. In #47, we left this out because we want to provide access to the underlying subscription. But since we can just give the user the ability to unsubscribe by returning the unsubscribe function inside the observer, perhaps it's better to use this method so we can simplify the API and remove the need for a cleanup function.
@honestbonsai I wanted to create this as a draft PR since I am not sure if we actually want this change quite yet. But I don't think this repo has the option for that (or I couldn't find it).
Even though the tests pass, the CI seems to show there's some unhandled promise rejection errors underneath. See here.
Not sure why that is, but that's making me want to hold off on merging this unless we sort things out.