personal_unlockAccount works with any password

[StevenJNPearce]

Expected Behavior

Run ganache-cli -n , call personal_unlockAccount with one of the accounts listed under "Available Accounts" and a random string for the password. An error should be returned to the user.

Current Behavior

Run ganache-cli -n , call personal_unlockAccount with one of the accounts listed under "Available Accounts" and a random string for the password. The account is unlocked. It can be used to make transactions freely.

Steps to Reproduce (for bugs)

Above.

Context

This behavior is divergent from using a real ethereum client.

Your Environment

• Version used:
  2.2.1
• Operating System and version: Ubuntu 18.04

[davidmurdoch]

Thanks for reporting this @StevenJNPearce. This is actually by design. However, after discussing the current behavior, we're now considering changing the logic in the future (we may just disable this feature when the locked option is enabled. If we don't change the logic we'll update docs and/or add logging to clarify what it going on.

Thanks again!

[StevenJNPearce]

I think it is worth changing, I love the convenience of ganache but more often than not find myself spinning up a geth node as the sole miner on its own network - for serious development I have to be sure things are working the same way they do as with a real node.

[davidmurdoch]

This behavior may have changed in the upcoming version of ganache, but we need to investigate further before closing this issue.