This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
feat(filecoin): implement deal expiration #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmurdoch
approved these changes
Mar 17, 2021
davidmurdoch
changed the title
mikeseese
force-pushed
the
fix/filecoin-seed-randomization
branch
from
786f3c6
to
b0f85c1
Compare
mikeseese
force-pushed
the
feat/filecoin-deal-expiration
branch
from
d2c50be
to
6b0d54b
Compare
mikeseese
force-pushed
the
fix/filecoin-seed-randomization
branch
from
b0f85c1
to
76546b7
Compare
mikeseese
force-pushed
the
feat/filecoin-deal-expiration
branch
from
6b0d54b
to
7e40480
Compare
|
I got approval from @tcoulter on Slack to merge this without his review (I also got @davidmurdoch's approval to merge without Tim's approval). Tests fail in this PR due to not having fixes from #877 yet, but I'm going to apply fixes for that in a new PR and merge this for now to be done with it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements Deal Expiration (the act of changing a deal's state from Active to Expired after the specified duration)