Debugger: Move breakpoint down if the current line is a declaration #1317
Comments
Thank you for raising this issue! It has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you would like to keep this issue open, please respond with information about the current state of this problem. |
There has been no new activity on this issue since it was marked as stale 7 days ago, so it is being automatically closed. If you'd like help with this or a different problem, please open a new issue. Thanks! |
Thanks for your response! This issue is no longer considered stale and someone from the Truffle team will try to respond as soon as they can. |
Thank you for raising this issue! It has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you would like to keep this issue open, please respond with information about the current state of this problem. |
There has been no new activity on this issue since it was marked as stale 7 days ago, so it is being automatically closed. If you'd like help with this or a different problem, please open a new issue. Thanks! |
@haltman-at or @gnidan is this still an issue? |
Indeed, this remains unfixed. I'll reopen it. |
Thanks for your response! This issue is no longer considered stale and someone from the Truffle team will try to respond as soon as they can. |
1 similar comment
Thanks for your response! This issue is no longer considered stale and someone from the Truffle team will try to respond as soon as they can. |
OK, I've created PR #1882 to address this issue (at least partially). It's not perfect, but I think it should be good enough for the practical cases discussed here. Note that it only alters line-based breakpoints; if you manually advance onto a normally-skipped node with |
This has now been merged and released, so I'm closing it. Let me know if it's not sufficient. |
Breaking/stepping along variable declarations is natural, but if a breakpoint is set on one of these lines that is being skipped, the breakpoint is currently being skipped.
We should do what most normal debuggers do: move the breakpoint down to the next valid non-skipped line (or AST).
The text was updated successfully, but these errors were encountered: