Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Debugger: Move breakpoint down if the current line is a declaration #1317

Closed
mikeseese opened this issue Oct 3, 2018 · 11 comments
Closed

Debugger: Move breakpoint down if the current line is a declaration #1317

mikeseese opened this issue Oct 3, 2018 · 11 comments
Labels

Comments

@mikeseese
Copy link
Contributor

Breaking/stepping along variable declarations is natural, but if a breakpoint is set on one of these lines that is being skipped, the breakpoint is currently being skipped.

We should do what most normal debuggers do: move the breakpoint down to the next valid non-skipped line (or AST).

@stale
Copy link

stale bot commented Dec 2, 2018

Thank you for raising this issue! It has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you would like to keep this issue open, please respond with information about the current state of this problem.

@stale stale bot added the stale label Dec 2, 2018
@stale
Copy link

stale bot commented Dec 10, 2018

There has been no new activity on this issue since it was marked as stale 7 days ago, so it is being automatically closed. If you'd like help with this or a different problem, please open a new issue. Thanks!

@stale stale bot closed this as completed Dec 10, 2018
@gnidan gnidan reopened this Dec 10, 2018
@stale
Copy link

stale bot commented Dec 10, 2018

Thanks for your response! This issue is no longer considered stale and someone from the Truffle team will try to respond as soon as they can.

@stale stale bot removed the stale label Dec 10, 2018
@stale
Copy link

stale bot commented Feb 8, 2019

Thank you for raising this issue! It has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you would like to keep this issue open, please respond with information about the current state of this problem.

@stale stale bot added the stale label Feb 8, 2019
@stale
Copy link

stale bot commented Feb 22, 2019

There has been no new activity on this issue since it was marked as stale 7 days ago, so it is being automatically closed. If you'd like help with this or a different problem, please open a new issue. Thanks!

@stale stale bot closed this as completed Feb 22, 2019
@mikeseese
Copy link
Contributor Author

@haltman-at or @gnidan is this still an issue?

@haltman-at
Copy link
Contributor

Indeed, this remains unfixed. I'll reopen it.

@haltman-at haltman-at reopened this Feb 22, 2019
@stale
Copy link

stale bot commented Feb 22, 2019

Thanks for your response! This issue is no longer considered stale and someone from the Truffle team will try to respond as soon as they can.

1 similar comment
@stale
Copy link

stale bot commented Feb 22, 2019

Thanks for your response! This issue is no longer considered stale and someone from the Truffle team will try to respond as soon as they can.

@haltman-at
Copy link
Contributor

OK, I've created PR #1882 to address this issue (at least partially). It's not perfect, but I think it should be good enough for the practical cases discussed here. Note that it only alters line-based breakpoints; if you manually advance onto a normally-skipped node with ;, and then place a node-based breakpoint with a bare b, sorry, that one's not getting adjusted (at least not as the PR is currently written). But I don't expect that to come up too often, so I thought it was OK to ignore that case.

@haltman-at
Copy link
Contributor

This has now been merged and released, so I'm closing it. Let me know if it's not sufficient.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants