Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off Solidity optimizer by default #543

Closed
tcoulter opened this issue Aug 22, 2017 · 5 comments
Closed

Turn off Solidity optimizer by default #543

tcoulter opened this issue Aug 22, 2017 · 5 comments

Comments

@tcoulter
Copy link
Contributor

@tcoulter tcoulter commented Aug 22, 2017

See here:
trufflesuite/truffle-compile#5

Note for users navigating here: To get the previous optimization settings, add the following to your truffle.js configuration.

optimizer: {
  "enabled": true,
  "runs": 200
}

See the solc configuration value for more.

@gnidan

This comment has been minimized.

Copy link
Member

@gnidan gnidan commented Oct 4, 2017

This likely involves increasing the gas limit, as tests are likely to fail.

@gnidan

This comment has been minimized.

Copy link
Member

@gnidan gnidan commented Oct 26, 2017

Potential problems, turning optimizer off:

  • Assert is too big
    Potential solution: Increase block gas limit for testing.
  • Ensure "test" and "develop" networks both respect the config gasLimit
@gnidan

This comment has been minimized.

Copy link
Member

@gnidan gnidan commented Oct 30, 2017

Optimizer was previously set to:

optimizer: {
  "enabled": true,
  "runs": 200
}

New setting sets enabled to false (and keeps runs at 200 for default)

@gnidan gnidan closed this Nov 1, 2017
@elie222

This comment has been minimized.

Copy link

@elie222 elie222 commented Jan 22, 2018

Why was this switched off?

@elie222

This comment has been minimized.

Copy link

@elie222 elie222 commented Jan 22, 2018

Ah I see the issue at the top. Anyone know how much extra gas things cost without optimization?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.