This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Internal improvement: Implement GHA CI for Node 8.x, 10.x, & 12.x #2337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CruzMolina
force-pushed
the
testNodeBuilds
branch
3 times, most recently
from
b8c5e9f
to
289e1ec
Compare
CruzMolina
force-pushed
the
testNodeBuilds
branch
from
289e1ec
to
c390865
Compare
CruzMolina
force-pushed
the
testNodeBuilds
branch
from
3444b86
to
0530035
Compare
CruzMolina
changed the title
|
This is really cool. Is this safe to merge? What else do we need to do? Hook up to slack? |
CruzMolina
force-pushed
the
testNodeBuilds
branch
2 times, most recently
from
71b0a24
to
e9999ed
Compare
CruzMolina
force-pushed
the
testNodeBuilds
branch
from
e9999ed
to
f15d1a5
Compare
CruzMolina
force-pushed
the
testNodeBuilds
branch
from
11bee98
to
26a89e7
Compare
|
@gnidan, looks like this is ready to go |
gnidan
approved these changes
Aug 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR leverages Github Actions to run CI checks against Node 8.x, 10.x, & 12.x on Ubuntu. Trims Travis' workload and keeps Travis jobs for Fabric EVM & Coveralls tests (for now).
Also adds Slack Notifications for when a workflow fails or when the build workflow job succeeds.