Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

truffle networks only reads JSON files #2909

Merged
merged 1 commit into from Mar 26, 2020
Merged

truffle networks only reads JSON files #2909

merged 1 commit into from Mar 26, 2020

Conversation

rkalis
Copy link
Contributor

@rkalis rkalis commented Mar 24, 2020

closes #2906

  • truffle networks [--clean] used to fail with non-JSON files
    in the directory. These non-JSON files are now ignored.

@gnidan
Copy link
Contributor

gnidan commented Mar 25, 2020

Hey @rkalis, our build was broken when you opened this PR, and now it is fixed! Could you please rebase so we can get the green check marks? Thanks for opening this :)

closes #2906
- truffle networks [--clean] used to fail with non-JSON files
  in the directory. These non-JSON files are now ignored.
@rkalis
Copy link
Contributor Author

rkalis commented Mar 25, 2020

Done :)

Copy link
Contributor

@gnidan gnidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@gnidan gnidan requested a review from eggplantzzz March 25, 2020 19:56
@haltman-at haltman-at self-requested a review March 26, 2020 19:41
Copy link
Contributor

@haltman-at haltman-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I'll add my approval!

@haltman-at haltman-at merged commit 603ef85 into trufflesuite:develop Mar 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

truffle-networks fails when non artifacts in build folder
3 participants