This repository has been archived by the owner on Mar 11, 2024. It is now read-only.
Feature/eslint config changes #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will enforce line style in next commit.
All other instances have been fixed. 🩹
This checks the syntax of our commits. adding some constancy to the process of commiting with a decent message. A rod for my own back.
Adding more info in the CONTRIBUTING.md file for the correct syntax. 📝
…fig-changes # Conflicts: # package.json # src/commands/DebuggerCommands.ts # src/commands/TruffleCommands.ts # src/helpers/truffleConfig.ts # src/helpers/userInteraction.ts # src/helpers/workspace.ts # test/TruffleCommandsTests/WriteToBuffer.test.ts # test/TruffleCommandsTests/buildContracts.test.ts # test/TruffleCommandsTests/deployContracts.test.ts # test/commands/DebuggerCommands.test.ts
xhulz
approved these changes
Jul 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to the codebase to cleanup and give us consistent code style, commit messages and linting where needed.
This is part of another commit that fixes the truffle configuration as a result of enabling some more of the ESLINT rules.