Don't use int constants (for attributes, etc) #16

stain opened this Issue Jul 18, 2013 · 1 comment


None yet

2 participants


This does not make sense to me when reading in a PROV-JSON file:

>>> bundle.get_records(ProvActivity)[0].get_attributes()[0].keys()
[101, 102]

How am I meant to know what 101 and 102 are? Look up among the hardcoded constants?

I don't see what purpose these integer constants serve (perhaps this is a leftover from a C-version of the code?), so I would get rid of them and simply use normal strings like "startTime" or "prov:startTime".

@trungdong trungdong added a commit that referenced this issue Apr 25, 2014
@trungdong prov.model: Changed PROV_REC int constants to the corresponding quali…
…fied names (related to #16)

Release 1.0.0 now uses appropriate qualified names as attribute names.

@trungdong trungdong closed this Jul 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment