Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Don't use int constants (for attributes, etc) #16

Closed
stain opened this Issue · 1 comment

2 participants

Stian Soiland-Reyes Dong Huynh
Stian Soiland-Reyes

This does not make sense to me when reading in a PROV-JSON file:

>>> bundle.get_records(ProvActivity)[0].get_attributes()[0].keys()
[101, 102]

How am I meant to know what 101 and 102 are? Look up among the hardcoded constants?

I don't see what purpose these integer constants serve (perhaps this is a leftover from a C-version of the code?), so I would get rid of them and simply use normal strings like "startTime" or "prov:startTime".

Dong Huynh
Owner

Release 1.0.0 now uses appropriate qualified names as attribute names.

Dong Huynh trungdong closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.