Change type, label, and value constant names for consistency #42

Closed
bruth opened this Issue May 23, 2014 · 1 comment

Comments

Projects
None yet
2 participants
@bruth
Contributor

bruth commented May 23, 2014

This is an observation, but these constants do not contain the _ATTR part of their names like the other attribute constants.

@trungdong

This comment has been minimized.

Show comment
Hide comment
@trungdong

trungdong May 4, 2017

Owner

I agree but am still inclined to keep these as they are (without the _ATTR) as they are frequently used while modelling provenance (by the library's users). The _ATTR constants, on the other hand, are typically used internally by the library only.

Owner

trungdong commented May 4, 2017

I agree but am still inclined to keep these as they are (without the _ATTR) as they are frequently used while modelling provenance (by the library's users). The _ATTR constants, on the other hand, are typically used internally by the library only.

@trungdong trungdong closed this May 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment