From 9b2f32f73d81646b01cf10708becd0d4f85e55dd Mon Sep 17 00:00:00 2001
From: Tyler Jang <tyler@trunk.io>
Date: Mon, 6 May 2024 17:15:05 -0700
Subject: [PATCH] fix fmt and add test case

---
 linters/biome/biome.test.ts                   | 19 +++++++++-
 linters/biome/plugin.yaml                     |  2 +-
 .../test_data/biome_v1.4.1_error.check.shot   | 36 +++++++++++++++++++
 .../test_data/biome_v1.6.0_error.check.shot   | 36 +++++++++++++++++++
 4 files changed, 91 insertions(+), 2 deletions(-)
 create mode 100644 linters/biome/test_data/biome_v1.4.1_error.check.shot
 create mode 100644 linters/biome/test_data/biome_v1.6.0_error.check.shot

diff --git a/linters/biome/biome.test.ts b/linters/biome/biome.test.ts
index d0b29b37b..76425a373 100644
--- a/linters/biome/biome.test.ts
+++ b/linters/biome/biome.test.ts
@@ -1,5 +1,22 @@
-import { linterCheckTest, linterFmtTest } from "tests";
+import path from "path";
+import { customLinterCheckTest, linterCheckTest, linterFmtTest } from "tests";
+import { TrunkLintDriver } from "tests/driver";
+import { TEST_DATA } from "tests/utils";
 
 linterCheckTest({ linterName: "biome", namedTestPrefixes: ["basic_check"] });
 
 linterFmtTest({ linterName: "biome", namedTestPrefixes: ["basic_fmt", "basic_json"] });
+
+const preCheck = (driver: TrunkLintDriver) => {
+  // Write an invalid biome config and verify we surface an error for format.
+  // NOTE(Tyler): We should handle config errors better for 'lint' too, but the JSON
+  // output for biome is not stable and they don't support SARIF.
+  driver.writeFile("biome.json", JSON.stringify({ rules: { "no-foo": "error" } }));
+};
+
+customLinterCheckTest({
+  linterName: "biome",
+  testName: "error",
+  args: path.join(TEST_DATA, "basic_check.in.ts"),
+  preCheck,
+});
diff --git a/linters/biome/plugin.yaml b/linters/biome/plugin.yaml
index 5a7410168..a4b7a65a9 100644
--- a/linters/biome/plugin.yaml
+++ b/linters/biome/plugin.yaml
@@ -30,7 +30,7 @@ lint:
         - name: fmt
           output: rewrite
           run: biome format --write "${target}"
-          success_codes: [0, 1]
+          success_codes: [0]
           batch: true
           cache_results: true
           formatter: true
diff --git a/linters/biome/test_data/biome_v1.4.1_error.check.shot b/linters/biome/test_data/biome_v1.4.1_error.check.shot
new file mode 100644
index 000000000..c60995917
--- /dev/null
+++ b/linters/biome/test_data/biome_v1.4.1_error.check.shot
@@ -0,0 +1,36 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`Testing linter biome test error 1`] = `
+{
+  "issues": [],
+  "lintActions": [
+    {
+      "command": "lint",
+      "fileGroupName": "typescript",
+      "linter": "biome",
+      "paths": [
+        "test_data/basic_check.in.ts",
+      ],
+      "verb": "TRUNK_VERB_CHECK",
+    },
+    {
+      "command": "lint",
+      "fileGroupName": "typescript",
+      "linter": "biome",
+      "paths": [
+        "test_data/basic_check.in.ts",
+      ],
+      "upstream": true,
+      "verb": "TRUNK_VERB_CHECK",
+    },
+  ],
+  "taskFailures": [
+    {
+      "details": StringMatching /\\.\\*\\$/m,
+      "message": "test_data/basic_check.in.ts",
+      "name": "biome",
+    },
+  ],
+  "unformattedFiles": [],
+}
+`;
diff --git a/linters/biome/test_data/biome_v1.6.0_error.check.shot b/linters/biome/test_data/biome_v1.6.0_error.check.shot
new file mode 100644
index 000000000..c60995917
--- /dev/null
+++ b/linters/biome/test_data/biome_v1.6.0_error.check.shot
@@ -0,0 +1,36 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`Testing linter biome test error 1`] = `
+{
+  "issues": [],
+  "lintActions": [
+    {
+      "command": "lint",
+      "fileGroupName": "typescript",
+      "linter": "biome",
+      "paths": [
+        "test_data/basic_check.in.ts",
+      ],
+      "verb": "TRUNK_VERB_CHECK",
+    },
+    {
+      "command": "lint",
+      "fileGroupName": "typescript",
+      "linter": "biome",
+      "paths": [
+        "test_data/basic_check.in.ts",
+      ],
+      "upstream": true,
+      "verb": "TRUNK_VERB_CHECK",
+    },
+  ],
+  "taskFailures": [
+    {
+      "details": StringMatching /\\.\\*\\$/m,
+      "message": "test_data/basic_check.in.ts",
+      "name": "biome",
+    },
+  ],
+  "unformattedFiles": [],
+}
+`;