New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create separately tagged image for Packer #14

Merged
merged 1 commit into from Feb 1, 2019

Conversation

Projects
None yet
3 participants
@brainsik
Copy link
Member

brainsik commented Feb 1, 2019

With the additional requirement of Ansible for the same project that required Packer, it's really not making sense to just shove everything all our projects need onto the same primary image.

This PR creates an additional "packer" tagged version of the primary image. It uses the primary image as the base and then adds Packer and Ansible to it.

  • Packer v1.3.4
  • Ansible v2.7.6
@chrisgilmerproj
Copy link
Contributor

chrisgilmerproj left a comment

🚀 - Thanks for doing this. I started to feel like having packer was just a little to much for MilMove. But this creates a nice pattern for other projects that have specific dependencies.

@kilbergr
Copy link

kilbergr left a comment

I think this is ok but would you mind walking me through it for learning purposes please?

name: Check for reserved branch names
command: |
if [[ $CIRCLE_BRANCH = latest || $CIRCLE_BRANCH = packer ]]; then
echo 'Can not use branches named "latest" or "packer" as these as meaningful tags.'

This comment has been minimized.

@kilbergr

kilbergr Feb 1, 2019

This sentence doesn't make sense--I've edited to what I think you meant and fixed a typo:
'Cannot use branches named "latest" or "packer" as these are meaningful tags.'

@brainsik brainsik force-pushed the packer-branch branch from b784bf9 to ff7df27 Feb 1, 2019

@brainsik brainsik force-pushed the packer-branch branch from ff7df27 to 03b0446 Feb 1, 2019

@brainsik brainsik merged commit d1a2b3b into master Feb 1, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@brainsik brainsik deleted the packer-branch branch Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment