Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that the USER is set properly #34

Merged
merged 1 commit into from Jun 10, 2019

Conversation

Projects
None yet
2 participants
@brainsik
Copy link
Member

commented Jun 7, 2019

Finally, some sort of test! :-)

This one simply ensures the image is properly set to run as the circleci user. Got bit by this today.

@chrisgilmerproj
Copy link
Contributor

left a comment

🚀 - Very interesting! How did you get bit by this?

@brainsik

This comment has been minimized.

Copy link
Member Author

commented Jun 10, 2019

🚀 - Very interesting! How did you get bit by this?

By the trailing backslash at the end of this line:

&& rm -rf circleci-cli_0.1.5607_linux_amd64 circleci-cli_0.1.5607_linux_amd64.tar.gz \

When I added a USER, it did nothing. I have no idea what's happening here / why there was no error or anything. Maybe something weird about how Docker parses the file. Also makes me wonder if the CMD was being actioned, I'm guessing it wasn't, but that's set to the same thing in the base image so doesn't matter. We don't actually need that line, I believe.

@brainsik brainsik merged commit e917945 into master Jun 10, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@brainsik brainsik deleted the lets-test branch Jun 10, 2019

@chrisgilmerproj

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

Wow. I have a feeling you're right, that the command wasn't working before. Glad you caught it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.