Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add assign_public_id variable #35

Merged
merged 5 commits into from Jan 7, 2020
Merged

add assign_public_id variable #35

merged 5 commits into from Jan 7, 2020

Conversation

@kilbergr
Copy link
Contributor

kilbergr commented Jan 7, 2020

Corresponds to this ticket

In order to make it possible to make ECS accessible from the public internet, needed to create a module variable to pass into the assign_public_ips internal variable. This blocks other work.

One question:
we're inconsistent about using bools vs strings as var types in tf12; I stuck with what we're using elsewhere in the module, but can update the whole module to use bools instead. What do you think?

Formatting for a number of these variables was autoupdated on commit via pre commit hooks.

kilbergr added 2 commits Jan 7, 2020
Copy link

esacteksab left a comment

I personally dislike using string as a bool and would prefer we used bool. I have noticed the convention and I wasn't sure why it existed. I'm approving this because when in Rome, but if this is opportunity to correct course, I'd love to.

variables.tf Outdated Show resolved Hide resolved
@chrisgilmerproj

This comment has been minimized.

Copy link
Contributor

chrisgilmerproj commented Jan 7, 2020

we're inconsistent about using bools vs strings as var types in tf12; I stuck with what we're using elsewhere in the module, but can update the whole module to use bools instead. What do you think?

Change them over. This was likely caused because of the tf11 -> tf12 work where we didn't explicitly look for strings we'd used as bools. Update them as you come across them.

Copy link
Contributor

chrisgilmerproj left a comment

Blocking while you update the variable types. Ping me directly in Slack and I'll unblock so you aren't stuck waiting on me.

kilbergr added 2 commits Jan 7, 2020
main.tf Outdated Show resolved Hide resolved
Copy link
Contributor

chrisgilmerproj left a comment

🚀 - There's one typo but otherwise this is great. Thanks!

Co-Authored-By: Chris Gilmer <chris@truss.works>
@kilbergr kilbergr merged commit 26cf4b5 into master Jan 7, 2020
1 check was pending
1 check was pending
ci/circleci: validate Your tests are queued behind your running builds
Details
@kilbergr kilbergr deleted the rek_public_ip_condition branch Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.