Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup for tf12; remove environment var; add arbitrary tags #1

Merged
merged 6 commits into from Jan 3, 2020

Conversation

@cblkwell
Copy link
Contributor

cblkwell commented Jan 2, 2020

This is to clean up some of the stuff that is lingering from its legacy as a MilMove internal module. The big changes are:

  • Reformat variable calls into tf12 format
  • Remove MilMove-specific documentation URL.
  • Remove the environment input variable because this should operate at an account level, not environment level.
  • Add the ability to add arbitrary additional tags in addition to the Name tag; used the method described in this issue: hashicorp/terraform#2283

I can confirm that this successfully plans with these changes; I confirmed that the arbitrary tag method works:

  + resource "aws_cloudwatch_log_group" "main" {
      + arn               = (known after apply)
      + id                = (known after apply)
      + name              = "/aws/lambda/iam-keys-check"
      + retention_in_days = 90
      + tags              = {
          + "Name"   = "iam-keys-check"
          + "things" = "stuff"
        }
    }

Note: This changes the name for a number of the resources, which used to be iam-keys-check-$env, now it's just iam-keys-check.

@cblkwell cblkwell requested review from chrisgilmerproj and dynamike Jan 2, 2020
cblkwell added 2 commits Jan 2, 2020
@chrisgilmerproj chrisgilmerproj requested a review from mr337 Jan 2, 2020
.terraform-version Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
@cblkwell cblkwell requested a review from dynamike Jan 2, 2020
Copy link
Collaborator

chrisgilmerproj left a comment

🚀 - looks good but we haven't had a chance to test. I'll be able to give you more information next week probably.

@cblkwell cblkwell merged commit cfbfd42 into master Jan 3, 2020
1 check passed
1 check passed
ci/circleci: validate Your tests passed on CircleCI!
Details
@cblkwell cblkwell deleted the cblkwell-release-cleanup branch Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.