Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update circleci docker image #22

Merged
merged 2 commits into from Jun 7, 2019

Conversation

Projects
None yet
2 participants
@chrisgilmerproj
Copy link
Contributor

commented Jun 6, 2019

The docker image is pretty old for testing against.

| region | Region where the AWS S3 bucket will be created. | string | - | yes |
| s3\_bucket\_name | S3 bucket to store AWS logs in. | string | - | yes |
| s3\_log\_bucket\_retention | Number of days to keep AWS logs around. | string | `90` | no |
| alb\_logs\_prefix | S3 prefix for ALB logs. | string | `"alb"` | no |

This comment has been minimized.

Copy link
@sojeri

sojeri Jun 6, 2019

Contributor

this change looks related to pre-commit rather than updating circleCI image

This comment has been minimized.

Copy link
@chrisgilmerproj

chrisgilmerproj Jun 7, 2019

Author Contributor

Surprisingly this actually belongs in this PR. In PR #21 the version of terraform-docs from the docker image is older (v0.5.0 I think) and so the terraform docs were correct still even though I updated the pre-commit hook versions. That's because the pre-commit hook version doesn't specify the terraform-docs version. But in this docker image the terraform-docs version is 0.6.0 and so the tests won't pass unless I also update these docs.

It seems weird but its supposed to work this way :)

@sojeri

sojeri approved these changes Jun 6, 2019

Copy link
Contributor

left a comment

signoff with the assumption that you'll move the markdown change to the pre-commit PR :)

@chrisgilmerproj chrisgilmerproj merged commit 1dc40a2 into master Jun 7, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@chrisgilmerproj chrisgilmerproj deleted the cg_update_docker_image branch Jun 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.