Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow an NLB to log to the S3 logging bucket #27

Merged
merged 1 commit into from Jul 10, 2019

Conversation

@chrisgilmerproj
Copy link
Contributor

commented Jul 8, 2019

I discovered that the NLB is not doing access logging in trussworks/terraform-aws-nlb-containers#9. However, to enable access logging the bucket must allow the NLB to write.

@chrisgilmerproj chrisgilmerproj self-assigned this Jul 8, 2019

@chrisgilmerproj chrisgilmerproj requested review from brainsik, sojeri, pjdufour-truss, rdhariwal, dynamike and cblkwell and removed request for brainsik Jul 8, 2019

@rdhariwal
Copy link

left a comment

:shipit:

@chrisgilmerproj chrisgilmerproj force-pushed the cg_nlb_logs branch from 1ab702e to c92d4d2 Jul 10, 2019

@chrisgilmerproj

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

The policy was tested in AWS and it does allow access for the NLB to send logs to S3.

@chrisgilmerproj chrisgilmerproj merged commit 5b53379 into master Jul 10, 2019

1 check passed

ci/circleci: validate Your tests passed on CircleCI!
Details

@chrisgilmerproj chrisgilmerproj deleted the cg_nlb_logs branch Jul 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.