Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nlb_logs_prefixes instead of nlb_logs_prefix #45

Merged
merged 7 commits into from Feb 11, 2020
Merged

Conversation

@pjdufour-truss
Copy link
Contributor

pjdufour-truss commented Feb 10, 2020

This PR add support for a custom list of NLB prefixes that reflects how the ALB prefixes is handled.

Copy link

cblkwell left a comment

I'm not sure about these changes; I don't have a problem with making the prefixes a list, but I don't see why we should get rid of the nlb_accounts variable?

main.tf Show resolved Hide resolved
@pjdufour-truss pjdufour-truss requested a review from cblkwell Feb 11, 2020
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Contributor

chrisgilmerproj left a comment

🚀 - I haven't run this on my infra yet but it looks exactly like I'd expect. Thanks!

variables.tf Outdated Show resolved Hide resolved
@pjdufour-truss pjdufour-truss requested a review from dynamike Feb 11, 2020
@pjdufour-truss pjdufour-truss merged commit f290672 into master Feb 11, 2020
1 check passed
1 check passed
ci/circleci: validate Your tests passed on CircleCI!
Details
@pjdufour-truss pjdufour-truss deleted the nlb_vars branch Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.