Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GovCloud #46

Merged
merged 6 commits into from Feb 13, 2020
Merged

Add support for GovCloud #46

merged 6 commits into from Feb 13, 2020

Conversation

@dynamike
Copy link
Contributor

dynamike commented Feb 13, 2020

GovCloud is different in very specials ways. The most painful is having a completely seperate AWS partition which makes ARNs different. It's arn:aws for commercial AWS and arn:aws-us-gov for GovCloud. This PR uses the https://www.terraform.io/docs/providers/aws/d/partition.html data source to look up the partition dynamically.

Terratests pass in AWS a commercial account, but still need to be verified in a GovCloud account.

ok  	github.com/trussworks/terraform-aws-logs/test	648.968s
@dynamike dynamike requested a review from trussworks/terraform Feb 13, 2020
Copy link
Contributor

chrisgilmerproj left a comment

🚀

dynamike added 5 commits Feb 13, 2020
Copy link

cblkwell left a comment

making a note here, great success:

module.logs_test.aws_s3_bucket.aws_logs: Creating...
module.logs_test.aws_s3_bucket.aws_logs: Creation complete after 6s
@dynamike dynamike merged commit 2897a19 into master Feb 13, 2020
1 check passed
1 check passed
ci/circleci: validate Your tests passed on CircleCI!
Details
@dynamike dynamike deleted the mk-govcloud branch Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.