Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new variables #17

Merged
merged 8 commits into from Feb 11, 2020
Merged

Add new variables #17

merged 8 commits into from Feb 11, 2020

Conversation

@pjdufour-truss
Copy link
Contributor

pjdufour-truss commented Feb 10, 2020

This PR adds 3 new variables that were copied over from the alb terraform module.

  • target_group_name
  • health_check_timeout
  • health_check_interval.

Does not change default behavior.

Reference:

Copy link
Contributor

chrisgilmerproj left a comment

🚀

@pjdufour-truss

This comment has been minimized.

Copy link
Contributor Author

pjdufour-truss commented Feb 10, 2020

Looks like custom timeouts are not supported, so removing that from this PR.

Error: Error creating LB Target Group: InvalidConfigurationRequest: Custom health check timeouts are not supported for health checks for target groups with the TCP protocol
	status code: 400, request id: XYZ
@pjdufour-truss pjdufour-truss merged commit d1766d5 into master Feb 11, 2020
1 check passed
1 check passed
ci/circleci: validate Your tests passed on CircleCI!
Details
@pjdufour-truss pjdufour-truss deleted the target_group_name branch Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.