Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for 'API Version' parameter for Client initialisation. #3

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@cgddrd
Copy link

commented Mar 13, 2019

This PR adds support for specifying the API version you wish to use when connecting to the Trustpilot API. The format for this parameter is v<n> where <n> is the version you wish to use (e.g. v1, v2 etc.)

Given that the Trustpilot API remains at v1 at the time of writing, this is the default if api_version is not specified.

The motivation behind this PR is to prevent the need to include the API version in subsequent URLs when using the client to call the Trustpilot API.

Connor Goddard
Added new 'API version' parameter for client and propagated changes t…
…hrough dependents. Documentation updated also.
@sloev

This comment has been minimized.

Copy link

commented on 4c9d4db Feb 18, 2019

this is great, wanna merge to upstream? :-)

This comment has been minimized.

Copy link
Owner

replied Feb 18, 2019

@sloev - yes I plan to, but have been having a spot of bother getting the tests running. I've left a new issue on your repo.

@cgddrd

This comment has been minimized.

Copy link
Author

commented Mar 16, 2019

@sloev - Ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.