diff --git a/SUMMARY.md b/SUMMARY.md index 65d938b3..372431e4 100644 --- a/SUMMARY.md +++ b/SUMMARY.md @@ -21,6 +21,7 @@ * [DApp](wallet-connect/dapp.md) * [Assets](assets/add_new_asset.md) * [DApps](assets/add-dapp.md) + * [Pull Request Fee](assets/pr-fee.md) * [Deep Linking](deeplinking/deeplinking.md) * [Staking](platform/staking.md) * [Roadmap](roadmap/roadmap.md) diff --git a/assets/add_new_asset.md b/assets/add_new_asset.md index c062f960..bbf2eddb 100644 --- a/assets/add_new_asset.md +++ b/assets/add_new_asset.md @@ -20,7 +20,7 @@ Token repository [https://github.com/trustwallet/assets](https://github.com/trus 4. [coins](https://github.com/satoshilabs/slips/blob/master/slip-0044.md) integrated in [Wallet Core](https://developer.trustwallet.com/wallet-core) -5. DApp images available in `Browser` section in Trust Wallet and at https://dapps.trustwallet.com and bookmarks icons. [read requirments](/assets/dapps) +5. DApp images available in `Browser` section in Trust Wallet and at https://dapps.trustwallet.com and bookmarks icons. [read requirments](assets/add-dapp.md) 6. Staking validators info available on [Trust Wallet Staking Platform](https://github.com/trustwallet/developer/blob/master/platform/staking.md) @@ -33,6 +33,7 @@ Token repository [https://github.com/trustwallet/assets](https://github.com/trus 1. Prepare image [requirements](#image-requirements) 2. Get familiar with [folder strcture](#repository-structure), will give you understanding where asset image should be placed 3. [Add asset guide](#how-to-add-asset) +4. Pay a [Pull Reqest Fee](assets/pr-fee.md) ## Image Requirements - file extension: `png`. Uppercase `PNG` considered invalid. diff --git a/assets/pr-fee.md b/assets/pr-fee.md new file mode 100644 index 00000000..12011772 --- /dev/null +++ b/assets/pr-fee.md @@ -0,0 +1,63 @@ +# Pull Request Fee -- FAQ + +**Someone is asking for cypto payment for processing my Pull Request. Is this a scam?** + +Always be cautious when someone asks you for payment. +Check that there is a description about it under Trust Wallet Developers' doucmentation (this page). +Check that the app is under the *trustwallet* github account, or that its owner belong to the trustwallet group. +So no, this is not a scam. + +**Why?** + +Trust Wallet supports an insane number of tokens and coins. +We are committed to supporting the tokens used by our users. +But supporting so many assets has a high cost, in terms of running the infrastructure, ensuring continuous integrations, +handling a massive number of requests to the assets info, etc. A lot of spam/scam coins also find us. + +We have introduced this crypto contribution in order to filter requests, so we have more time to handle genuine ones. + +We were partly insipred by [Token Curated Registry](https://medium.com/@tokencuratedregistry/a-simple-overview-of-token-curated-registries-84e2b7b19a06). + +**What do I have to pay attention to?** + +* Double check the [contribution guidelines](/add_new_asset), to minimize the risk of your PR being rejected. +* Make sure to set the correct memo on your transfer. + +**How does a Fee fit with Open Source?** + +We believe in the power of open-source software, and essential parts of Trust Wallet are open source to contribute to the community +([Wallet-Core](https://developer.trustwallet.com/wallet-core), [Blockatlas](https://developer.trustwallet.com/blockatlas)). +But Trust Wallet is a branded product and running its backend infrastructure, support, marketing, etc. +Has costs (done by a non-volunteer based team). + +The `assets` repository is open source. You are free to use it and free to create your version (fork). But we choose to ask for a contribution for requests to include/change the information in the Trust Wallet product. See also *Why* question. + +**What is Trust Wallet Token TWT?** + +TWT is a token used in the +[Referral Program](https://community.trustwallet.com/t/invite-a-friend-earn-trust-wallet-token-twt/4125). +Currently, it is only possible to obtain it through referrals. But if you are a token with a serious user base, getting a referral for ten new users should not be a problem. + +**When is my payment evaluated?** + +Payment is handled by [`merge-fee-bot`](https://github.com/settings/apps/merge-fee-bot), a GitHub app by us. +Currently, payment is checked only when there is some action on the PR, such as a comment. +So after your transfer, create a comment about it. The payment should be detected within seconds. +(Technical background: being notified when the payment happens is not a problem, but interacting with a PR +when there is no action on it is difficult for the GitHub app.) + +**What happens after I pay? Is merging automatic?** + +When the `merge-fee-bot` detects payment, it automatically places an Accept review on the PR. +This is a precondition for merge. +But merging is currently not automatic, it is done by the maintainers. + +**I have forgot to set a memo in my transfer** + +You know crypto, how transactions are final and irreversible. We warned, provided QR code with memo, sorry. +Pay again with correct memo. + +**If you decide not to merge my PR, do I get my payment back?** + +If a PR is rejected, it must have a reason. Double check the contribution guide before paying. +The fee is for processing a pull request, not necessarily merging it.