Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove js bindings #590

Merged
merged 2 commits into from Aug 27, 2019

Conversation

@hewigovens
Copy link
Collaborator

commented Aug 26, 2019

Fixes #589

@hewigovens hewigovens force-pushed the xt/remove-js branch from 6519d76 to 8c1df8b Aug 26, 2019
@hewigovens hewigovens requested a review from leoneparise Aug 26, 2019
@codecov

This comment has been minimized.

Copy link

commented Aug 26, 2019

Codecov Report

Merging #590 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #590   +/-   ##
=======================================
  Coverage   83.28%   83.28%           
=======================================
  Files         264      264           
  Lines        5996     5996           
=======================================
  Hits         4994     4994           
  Misses       1002     1002

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1409703...0c3f075. Read the comment docs.

@hewigovens hewigovens requested review from madcake and ArtemGoryunov Aug 27, 2019
@hewigovens hewigovens merged commit 5bb4df8 into master Aug 27, 2019
6 checks passed
6 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Wallet Core Android #9783 succeeded
Details
Wallet Core Linux #9785 succeeded
Details
Wallet Core iOS #9784 succeeded
Details
codecov/patch Coverage not affected when comparing 1409703...0c3f075
Details
codecov/project 83.28% remains the same compared to 1409703
Details
@hewigovens hewigovens deleted the xt/remove-js branch Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.