-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Harmony #626
Merged
Merged
Add Harmony #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #626 +/- ##
==========================================
+ Coverage 84.04% 84.22% +0.18%
==========================================
Files 273 278 +5
Lines 6488 6594 +106
==========================================
+ Hits 5453 5554 +101
- Misses 1035 1040 +5
Continue to review full report at Codecov.
|
a54d94c
to
f9b947f
Compare
vikmeup
reviewed
Sep 5, 2019
vikmeup
reviewed
Sep 5, 2019
vikmeup
reviewed
Sep 5, 2019
vikmeup
reviewed
Sep 5, 2019
…move explicit nonmainnet enumeration
hewigovens
reviewed
Sep 6, 2019
hewigovens
reviewed
Sep 6, 2019
hewigovens
reviewed
Sep 6, 2019
hewigovens
reviewed
Sep 6, 2019
hewigovens
reviewed
Sep 6, 2019
hewigovens
reviewed
Sep 6, 2019
hewigovens
reviewed
Sep 6, 2019
hewigovens
reviewed
Sep 6, 2019
hewigovens
reviewed
Sep 6, 2019
hewigovens
reviewed
Sep 6, 2019
hewigovens
reviewed
Sep 6, 2019
hewigovens
reviewed
Sep 6, 2019
@fxfactorial left some comments, overall is not bad |
Co-Authored-By: hewig <360470+hewigovens@users.noreply.github.com>
Co-Authored-By: hewig <360470+hewigovens@users.noreply.github.com>
vikmeup
reviewed
Sep 7, 2019
hewigovens
approved these changes
Sep 8, 2019
vikmeup
approved these changes
Sep 8, 2019
created an issue for the address part: #635 |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Harmony to TrustWallet