Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Harmony #626

Merged
merged 34 commits into from
Sep 9, 2019
Merged

Add Harmony #626

merged 34 commits into from
Sep 9, 2019

Conversation

fxfactorial
Copy link
Contributor

Added Harmony to TrustWallet

@codecov
Copy link

codecov bot commented Sep 5, 2019

Codecov Report

Merging #626 into master will increase coverage by 0.18%.
The diff coverage is 95.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #626      +/-   ##
==========================================
+ Coverage   84.04%   84.22%   +0.18%     
==========================================
  Files         273      278       +5     
  Lines        6488     6594     +106     
==========================================
+ Hits         5453     5554     +101     
- Misses       1035     1040       +5
Impacted Files Coverage Δ
src/Harmony/Signer.h 100% <100%> (ø)
src/Harmony/Transaction.h 100% <100%> (ø)
src/interface/TWHarmonySigner.cpp 100% <100%> (ø)
src/Harmony/Signer.cpp 100% <100%> (ø)
src/Coin.cpp 93.75% <66.66%> (-2.31%) ⬇️
src/Harmony/Address.cpp 89.28% <89.28%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c98107a...de89244. Read the comment docs.

@hewigovens
Copy link
Contributor

@fxfactorial left some comments, overall is not bad

@hewigovens
Copy link
Contributor

created an issue for the address part: #635

@hewigovens hewigovens merged commit 50df64e into trustwallet:master Sep 9, 2019
@fxfactorial fxfactorial deleted the harmony-dev-edgar branch September 9, 2019 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants