From 464e8af57fe63d93bf729a2940a9cf7661817603 Mon Sep 17 00:00:00 2001 From: Mariano Fuentes Date: Wed, 20 May 2026 11:06:01 -0400 Subject: [PATCH 1/2] fix(people): ds component compatibility fixes for offboarding UI - remove redundant wrapper divs from PopoverContent (DS already renders card chrome) - remove className from PopoverContent (not accepted by DS) - use render prop on DropdownMenuTrigger to avoid nested buttons - use accent variant for Critical badge instead of destructive Co-Authored-By: Claude Opus 4.6 (1M context) --- .../components/OffboardingChecklistItem.tsx | 2 +- .../all/components/TeamMembersClient.tsx | 40 ++++++++----------- 2 files changed, 18 insertions(+), 24 deletions(-) diff --git a/apps/app/src/app/(app)/[orgId]/people/[employeeId]/components/OffboardingChecklistItem.tsx b/apps/app/src/app/(app)/[orgId]/people/[employeeId]/components/OffboardingChecklistItem.tsx index 88fa5f209..b84cd9277 100644 --- a/apps/app/src/app/(app)/[orgId]/people/[employeeId]/components/OffboardingChecklistItem.tsx +++ b/apps/app/src/app/(app)/[orgId]/people/[employeeId]/components/OffboardingChecklistItem.tsx @@ -92,7 +92,7 @@ function ItemBadges({ <> {item.isAccessRevocation && (
- Critical + Critical
)} {item.evidenceRequired && ( diff --git a/apps/app/src/app/(app)/[orgId]/people/all/components/TeamMembersClient.tsx b/apps/app/src/app/(app)/[orgId]/people/all/components/TeamMembersClient.tsx index 07dca17c4..c15587e68 100644 --- a/apps/app/src/app/(app)/[orgId]/people/all/components/TeamMembersClient.tsx +++ b/apps/app/src/app/(app)/[orgId]/people/all/components/TeamMembersClient.tsx @@ -661,8 +661,7 @@ function DateRangeFilter({ -
-
+
{label} between @@ -693,16 +692,14 @@ function DateRangeFilter({
-
- { setDraftFrom(d ?? undefined); setActivePreset(null); setFromPickerOpen(false); }} - captionLayout="dropdown" - fromYear={2000} - toYear={new Date().getFullYear() + 1} - /> -
+ { setDraftFrom(d ?? undefined); setActivePreset(null); setFromPickerOpen(false); }} + captionLayout="dropdown" + fromYear={2000} + toYear={new Date().getFullYear() + 1} + />
@@ -714,16 +711,14 @@ function DateRangeFilter({
-
- { setDraftTo(d ?? undefined); setActivePreset(null); setToPickerOpen(false); }} - captionLayout="dropdown" - fromYear={2000} - toYear={new Date().getFullYear() + 1} - /> -
+ { setDraftTo(d ?? undefined); setActivePreset(null); setToPickerOpen(false); }} + captionLayout="dropdown" + fromYear={2000} + toYear={new Date().getFullYear() + 1} + />
@@ -737,7 +732,6 @@ function DateRangeFilter({ -
From 7dc8e374f18c5fb71a766d51b4d804e1dcefad8a Mon Sep 17 00:00:00 2001 From: Mariano Fuentes Date: Wed, 20 May 2026 14:41:22 -0400 Subject: [PATCH 2/2] fix(people): override popover width for date range filter DS PopoverContent has hardcoded w-72 which clips the 380px filter content. Use inline style to override width to auto. Co-Authored-By: Claude Opus 4.6 (1M context) --- .../(app)/[orgId]/people/all/components/TeamMembersClient.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/app/src/app/(app)/[orgId]/people/all/components/TeamMembersClient.tsx b/apps/app/src/app/(app)/[orgId]/people/all/components/TeamMembersClient.tsx index c15587e68..8c23d36d6 100644 --- a/apps/app/src/app/(app)/[orgId]/people/all/components/TeamMembersClient.tsx +++ b/apps/app/src/app/(app)/[orgId]/people/all/components/TeamMembersClient.tsx @@ -660,7 +660,7 @@ function DateRangeFilter({ - +
{label} between