Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dual Samples #62

Closed
crogonint opened this issue Nov 13, 2019 · 13 comments · Fixed by #286
Closed

Dual Samples #62

crogonint opened this issue Nov 13, 2019 · 13 comments · Fixed by #286
Assignees
Labels
always-fresh Issues that will never become stale enhancement New feature or request
Milestone

Comments

@crogonint
Copy link

crogonint commented Nov 13, 2019

Some of the included samples are terribly irritating. An example is the Bonfire sample. It's about 1 1/2 seconds long, and for all the world sounds like somebody left a record player on after the record was finished.

Sounds which by nature will have a repetitive pattern like this one are easily masked, however. You simply have two separate samples of different lengths. For example, for this bonfire, I would recommend two samples, one eight seconds long, and one 15 seconds long. If you start them both at the same time, and repeat them both (assuming a smooth transition on both samples, of course), it would be several minutes before the pattern repeats.

Both samples should be of equal volume, and could both be controlled by the same volume selector. This functionality is simply to provide a non repetative sample, it's not necessary to have it appear as two separate samples. ;)

@crogonint crogonint added the enhancement New feature or request label Nov 13, 2019
@ashutoshgngwr
Copy link
Member

That's a neat idea. I want to give it a try for sure but I am finding it difficult to manage time to work on hobby projects these days. In the meantime, if you can take this up and ahead, I'll be happy to help. If not, I'll try to work on it but I can't promise anything. 😅

@crogonint
Copy link
Author

crogonint commented Nov 13, 2019

I've probably got some free to use sound samples already downloaded somewhere, from soundbible.com or one of the other ones from back in the day.

I don't do much programming these days though. I can pair up some samples, and make sure that they transition cleanly, but you'll have to hammer it in to the code. ;)

@ashutoshgngwr
Copy link
Member

@crogonint awesome. Please do that!

@ashutoshgngwr
Copy link
Member

@crogonint Whenever you can, send me the samples before due date of the milestone. I want to add better audio samples to next version.

@dector
Copy link

dector commented Jan 19, 2020

@crogonint can you share examples in this issue please?

@crogonint
Copy link
Author

crogonint commented Jan 22, 2020 via email

@crogonint
Copy link
Author

Just an FYI, I didn't forget about this, my sound samples are on a random drive that I haven't located yet. I'll be going through the drives today. Cross your fingers...

@stale stale bot removed the stale label Mar 28, 2020
@crogonint
Copy link
Author

@ashutoshgngwr

I was pretty happy with most of the samples already in use.

What bit rate would you like use as an HD standard?

@ashutoshgngwr
Copy link
Member

ashutoshgngwr commented Mar 28, 2020

@crogonint with current standard 128-192 kbps is what I'm considering to be the best quality for the sounds. Of course, this is after taking app size into consideration.

@crogonint
Copy link
Author

Yeah I don't think that 128kbps is totally necessary for most of these, I mean they're mostly ambient. I could maybe see birds, or people mumbling, or thunder.. Sounds that actually benefit from a higher sound density..

Tell you what, I use a lot of RPG sound thingies, I'll see what they're using as a standard for background noises and sounds.

@stale stale bot added stale and removed stale labels May 19, 2020
This was referenced Jun 15, 2020
@stale stale bot added the stale label Jul 7, 2020
@ashutoshgngwr ashutoshgngwr added always-fresh Issues that will never become stale and removed stale labels Jul 14, 2020
@ashutoshgngwr ashutoshgngwr removed this from the v0.3.0 milestone Sep 5, 2020
@ashutoshgngwr ashutoshgngwr added this to the 0.10.x milestone Sep 5, 2020
@crogonint
Copy link
Author

crogonint commented Oct 9, 2020

Just an update, I finally located my massive library of sample sounds! Woo-hoo!! Just want to let you know I didn't forget, I'll get this back around on the front burner sooner or later. Actually, if you're moving to hi-fidelity sounds, I'll have to double check the sample rates on my end. I use this stuff for sound effects mainly, so I'm not always very picky about getting the best sample rate. ;)

@ashutoshgngwr
Copy link
Member

@crogonint This is done, closed and released. Thanks for your input!

@crogonint
Copy link
Author

Congrats! I haven't seen an update come through lately, I'll check and see why I missed it. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
always-fresh Issues that will never become stale enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants