feat(ecmascript): FinalizationRegistry #900
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements half of #623. I also tried out using SoAVec as the storage for FinalizationRegistryRecords and it works pretty wonderfully from a code-organisation point of view at least. Methods that have to do with registration belong on the
Cellsstruct and touch only one cache line, methods that have to do with cleanup belong on theCleanupstruct and touch only one cache line, the backing object is a third cache line, and finally the only time when these cache lines interact is during GC. Nice.