chore(heap): Use SoAVec for Set storage #901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Some lints to fix at least. |
Reinsdyret
force-pushed
the
chore/set-soavec
branch
from
ad7b4c3 to
e0eedd6
Compare
aapoalas
force-pushed
the
chore/set-soavec
branch
from
e11b997 to
26535bf
Compare
aapoalas
approved these changes
Nov 26, 2025
Member
aapoalas
left a comment
aapoalas
left a comment
There was a problem hiding this comment.
Alright, LGTM! I fixed up the get/get_mut API's to return the Ref/Mut with the GC lifetime bound and took advantage of that in removing a couple of unbinds elsewhere (when assinging Values into the result from get_mut(_direct)).
I also rebased to main where I fixed the odd clippy error. That was caused by a too-old nightly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated set storage in heap from Vec to SoAVec.