refactor: 应用上传版本详情的 changelog_list 改名 array_changelog; 网络钩子的 changelog 默认输出 markdown 列表格式

Author: icyleaf

app/helpers/application_helper.rb

@@ -49,11 +49,7 @@ def active_class(link_paths, class_name = 'active')
   end
 
   def changelog_format(changelog, **options)
-    raw = changelog.each_with_object([]) do |line, obj|
-      obj << "- #{line['message']}"
-    end.join("\n")
-
-    simple_format raw, **options
+    simple_format changelog, **options
   end
 
   def device_name(device_type)

app/jobs/app_web_hook_job.rb

@@ -49,7 +49,7 @@ def build(body)
                                    release_version: @release.release_version,
                                    build_version: @release.build_version,
                                    bundle_id: @release.bundle_id,
-                                   changelog: @release.changelog,
+                                   changelog: @release.text_changelog,
                                    file_size: @release.file.size,
                                    release_url: @release.release_url,
                                    install_url: @release.install_url,

app/models/release.rb

@@ -121,13 +121,19 @@ def short_git_commit
     git_commit[0..8]
   end
 
-  def changelog_list(use_default_changelog = true)
+  def array_changelog(use_default_changelog = true)
     return empty_changelog(use_default_changelog) if changelog.blank?
     return [{'message' => changelog.to_s}] unless changelog.is_a?(Array) || changelog.is_a?(Hash)
 
     changelog
   end
 
+  def text_changelog(use_default_changelog = true)
+    array_changelog(use_default_changelog).each_with_object([]) do |line, obj|
+      obj << "- #{line['message']}"
+    end.join("\n")
+  end
+
   def file?
     return false if file.blank?
 

app/serializers/api/upload_app_serializer.rb

@@ -4,7 +4,7 @@ class Api::UploadAppSerializer < ApplicationSerializer
   # release model based
   attributes :id, :version, :app_name, :bundle_id, :release_version, :build_version,
              :source, :branch, :git_commit, :ci_url, :size,
-             :icon_url, :release_url, :install_url, :qrcode_url, :changelog_list,
+             :icon_url, :release_url, :install_url, :qrcode_url, :array_changelog,
              :custom_fields, :created_at
 
   belongs_to :app

app/serializers/release_serializer.rb

@@ -7,6 +7,6 @@ class ReleaseSerializer < ApplicationSerializer
              :created_at
 
   def changelog
-    object.changelog_list(false)
+    object.array_changelog(false)
   end
 end

app/views/dashboards/_recently_upload.html.slim

@@ -31,7 +31,7 @@ section
                       = t('dashboard.timeline.upload_release', release_version: release.release_version, build_version: release.build_version)
                     - if release.changelog.present?
                       .timeline-body.pb-1
-                        = changelog_format release.changelog_list, class: 'mb-0'
+                        = changelog_format release.text_changelog, class: 'mb-0'
                     - if release.release_type.present? || release.branch.present? || release.short_git_commit.present?
                       .timeline-footer
                         - if release.device_type

app/views/releases/body/_activity.html.slim

@@ -24,7 +24,7 @@ ruby:
                 = t('releases.show.upload_release', release_version: release.release_version, build_version: release.build_version)
               - if release.changelog.present?
                 .timeline-body.pb-0
-                  = changelog_format(release.changelog_list, class: 'mb-0')
+                  = changelog_format(release.text_changelog, class: 'mb-0')
               - if release.release_type.present? || release.branch.present? || release.short_git_commit.present?
                 .timeline-footer
                   - if release.device_type

app/views/releases/body/_changelog.html.slim

@@ -8,7 +8,7 @@
         i.fas.fa-minus
   .card-body.p-0
     ul.products-list.product-list-in-card
-      - @release.changelog_list.each do |changelog|
+      - @release.array_changelog.each do |changelog|
         li.item.pl-3.pr-3
           .product-title
             - if date = changelog['date']

app/views/udid/show.html.slim

@@ -75,7 +75,7 @@
                     = t('udid.show.upload_release', release_version: release.release_version, build_version: release.build_version)
                   - if release.changelog.present?
                     .timeline-body.pb-0
-                      = changelog_format release.changelog_list, class: 'mb-0'
+                      = changelog_format release.text_changelog, class: 'mb-0'
                   - if release.release_type.present? || release.branch.present? || release.short_git_commit.present?
                     .timeline-footer
                       - if release.release_type.present?