允许下载文件的名称与上传文件的名称保持一致 by rakuyoMo · Pull Request #1744 · tryzealot/zealot

rakuyoMo · 2024-11-27T01:56:31Z

施工中，自认为全部完成后会正式请求 review。

关联 issue #1611 (comment) ，拟作为#1735 的临时解决方案。

我只会一些 ruby 的皮毛，更未涉足过 Ruby on Rails。如果任何人有什么建议或者发现了什么问题，请随时和我沟通，谢谢您的帮助！

There may be omissions

welcome · 2024-11-27T01:56:34Z

感谢你提交的问题或反馈，我会在有时间的时候来审查代码。
Thanks so much for opening your first PR here!

icyleaf · 2024-11-27T03:43:09Z

一点想法：

把选项放到 release 每上传一次都要传一次是不是太麻烦了，不如放到上一层 channel 会更好一些。
原 issue 如果也提 PR 那岂不是又要多一个字段，而且都设置 true 怎么办，不如改成一个枚举字段 :D

现在应用的三层结构在定义一些设置有些繁琐，太粗太细都不合适，之前有计划规划设置 policy 模板，可以随意 apply 到任意一层，鉴于时间精力也不盈利的情况下一直在鸽

Issues-translate-bot · 2024-11-27T03:43:20Z

Bot translate issue to English automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Some thoughts:

Is it too troublesome to put the option in release? It has to be passed every time it is uploaded. It would be better to put it in the upper channel.
If the original issue also raises a PR, wouldn’t it require one more field, and both should be set to true? Why not change it to an enumeration field :D

The three-layer structure of the current application is a bit cumbersome to define some settings, and it is not suitable to be too thick or too detailed. I had previously planned to set up a policy template, which can be applied to any layer at will. In view of the fact that time and energy are not profitable, I have been pigeonholing it.

rakuyoMo · 2024-11-27T04:00:49Z

一点想法：

把选项放到 release 每上传一次都要传一次是不是太麻烦了，不如放到上一层 channel 会更好一些。

原 issue 如果也提 PR 那岂不是又要多一个字段，而且都设置 true 怎么办，不如改成一个枚举字段 :D

很好的建议，我会尝试将 use_original_filename 改为一个枚举并放到 channel 层。

目前打算提供 “原文件名” 和 “系统内置” 两个选项，“系统内置” 为默认值。本 pr 不考虑新增原 issue “完全自定义” 的情况。

Issues-translate-bot · 2024-11-27T04:01:02Z

Bot translate issue to English automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Some thoughts:

Isn’t it too troublesome to put the option in release? It has to be passed every time it is uploaded. It would be better to put it in the upper channel.

If the original issue also raises a PR, wouldn't it require one more field, and set both to true? Why not change it to an enumeration field :D

Good suggestion, I will try to change use_original_filename to an enum and put it in the channel layer.

It is currently planned to provide two options: "Original file name" and "System built-in", with "System built-in" being the default value. This PR does not consider the "completely customized" situation of adding the original issue.

Reference: tryzealot#1744 (comment)

1. Only control fields are added, and the file name logic for downloading has not yet been implemented 2. Swagger is not included 3. Channel information display is not included

rakuyoMo · 2024-11-27T10:15:38Z

@icyleaf 我自认为完成了相关逻辑，现在可以开始 review 了。

目前开启相关设置后，下载文件的文件名和上传时保持一致。未开启设置时依然和之前逻辑一致。

Issues-translate-bot · 2024-11-27T10:15:50Z

Bot translate issue to English automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@icyleaf I think I have completed the relevant logic and can now start reviewing.

icyleaf

会 Ruby 基本就会 Rails，别忘了 Rails 可以从入门到 IPO 的 slogan 😆

…ded file

…e logic

…es in channel details

icyleaf

修改完这个就可以合并了 😄

icyleaf

LGTM

welcome · 2024-11-30T02:47:20Z

感谢贡献 PR 来支持 Zealot! 🎉
Congrats on merging your first pull request here! 🎉 How awesome!

feat: Try adding use_original_filename at the logical level

3f163c6

There may be omissions

rakuyoMo added 4 commits November 27, 2024 10:20

feat: Try adding use_original_filename to web page

f04ea75

style: Add line breaks

90984a1

Merge branch 'develop' into feature/original-file-name

ab48b71

feat: Delete ToDo

c1832b4

icyleaf added the wip working in process label Nov 27, 2024

rakuyoMo added a commit to rakuyoMo/zealot that referenced this pull request Nov 27, 2024

refactor: Remove use_original_filename

753a2c7

Reference: tryzealot#1744 (comment)

refactor: Remove use_original_filename

e6c97cf

Reference: tryzealot#1744 (comment)

rakuyoMo force-pushed the feature/original-file-name branch from 753a2c7 to e6c97cf Compare November 27, 2024 06:45

feat: Add download_filename_type to channel

af4c3d8

1. Only control fields are added, and the file name logic for downloading has not yet been implemented 2. Swagger is not included 3. Channel information display is not included

rakuyoMo force-pushed the feature/original-file-name branch from 990cc18 to af4c3d8 Compare November 27, 2024 09:52

rakuyoMo added 3 commits November 27, 2024 17:59

feat: Add download_filename_type to channels metadata

83add9f

feat: Added logic to use the original file name when downloading

1cbfdd1

feat: Add download_filename_type to swagger

45e97cd

rakuyoMo marked this pull request as ready for review November 27, 2024 10:14

rakuyoMo commented Nov 27, 2024

View reviewed changes

Comment thread app/models/channel.rb

rakuyoMo commented Nov 27, 2024

View reviewed changes

Comment thread app/models/release.rb

icyleaf reviewed Nov 27, 2024

View reviewed changes

Comment thread app/models/channel.rb

Comment thread app/models/release.rb

Comment thread app/models/channel.rb Outdated

Comment thread config/locales/simple_form/simple_form.zh-CN.yml Outdated

icyleaf force-pushed the develop branch from ba2b26a to e32a6a1 Compare November 27, 2024 15:58

rakuyoMo added 4 commits November 28, 2024 09:04

Merge branch 'develop' into feature/original-file-name

f915ac1

feat: Update local text

0d63c70

refactor: Adjust the logic of processing the file name of the downloa…

6df8417

…ded file

refactor: Rename download_filename_type and adjust the default valu…

55d4671

…e logic

feat: Add more descriptions of the file name types for downloaded fil…

c3c3f89

…es in channel details

rakuyoMo commented Nov 28, 2024

View reviewed changes

Comment thread app/views/channels/_metadata.html.slim Outdated

feat: Optimize text and prompts

5e7e502

rakuyoMo force-pushed the feature/original-file-name branch from 5a81c7e to 5e7e502 Compare November 28, 2024 05:35

icyleaf removed the wip working in process label Nov 28, 2024

icyleaf reviewed Nov 29, 2024

View reviewed changes

Comment thread config/locales/zealot/en.yml Outdated

Comment thread config/locales/zealot/zh-CN.yml Outdated

Comment thread db/migrate/20241127143631_add_download_file_type_to_channel.rb

rakuyoMo added 2 commits November 29, 2024 13:17

feat: Optimize text and prompts

9ed480f

feat: Added download_filename_type value for old data

6ff8cf5

rakuyoMo force-pushed the feature/original-file-name branch from a43dcee to 6ff8cf5 Compare November 29, 2024 08:18

icyleaf requested changes Nov 29, 2024

View reviewed changes

Comment thread db/migrate/20241127143631_add_download_file_type_to_channel.rb

rakuyoMo added 2 commits November 30, 2024 09:08

Merge branch 'develop' into feature/original-file-name

7bc1e20

refactor: Improve the implementation of AddDownloadFileTypeToChannel

3297ec1

icyleaf approved these changes Nov 30, 2024

View reviewed changes

icyleaf merged commit 881b341 into tryzealot:develop Nov 30, 2024

rakuyoMo deleted the feature/original-file-name branch November 30, 2024 02:49

icyleaf mentioned this pull request May 18, 2025

Release 6.0.0 finally! #1922

Merged

Uh oh!

Uh oh!

Conversation

rakuyoMo commented Nov 27, 2024

Uh oh!

welcome Bot commented Nov 27, 2024

Uh oh!

icyleaf commented Nov 27, 2024

Uh oh!

Issues-translate-bot commented Nov 27, 2024

Uh oh!

rakuyoMo commented Nov 27, 2024

Uh oh!

Issues-translate-bot commented Nov 27, 2024

Uh oh!

rakuyoMo commented Nov 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Issues-translate-bot commented Nov 27, 2024

Uh oh!

Uh oh!

icyleaf left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

icyleaf left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

icyleaf left a comment

Choose a reason for hiding this comment

Uh oh!

welcome Bot commented Nov 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rakuyoMo commented Nov 27, 2024 •

edited

Loading