Skip to content

Add app search by name - #1864

Merged
icyleaf merged 2 commits into
tryzealot:developfrom
BraZucco:feature/search_app
Mar 22, 2025
Merged

Add app search by name#1864
icyleaf merged 2 commits into
tryzealot:developfrom
BraZucco:feature/search_app

Conversation

@BraZucco

Copy link
Copy Markdown
Contributor

No description provided.

@welcome

welcome Bot commented Mar 22, 2025

Copy link
Copy Markdown

感谢你提交的问题或反馈,我会在有时间的时候来审查代码。
Thanks so much for opening your first PR here!

@icyleaf icyleaf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you update the reviews?

Comment thread app/models/app.rb Outdated
Comment thread app/views/apps/index.html.slim Outdated
@icyleaf

icyleaf commented Mar 22, 2025

Copy link
Copy Markdown
Member

250322_10h41m43s_screenshot

I update the layout with patch file.

- Changing the scope to search_by_name
- Changing the query to use ILIKE for case-insensitive searches
- Applying .diff to fix the search layout
@BraZucco
BraZucco requested a review from icyleaf March 22, 2025 05:09
@icyleaf
icyleaf merged commit d0b08ce into tryzealot:develop Mar 22, 2025
@welcome

welcome Bot commented Mar 22, 2025

Copy link
Copy Markdown

感谢贡献 PR 来支持 Zealot! 🎉
Congrats on merging your first pull request here! 🎉 How awesome!
Congrats!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants