Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added functionality to allow returning wrapped classes from member functions #13

wants to merge 6 commits into


None yet
2 participants

tsa commented Nov 2, 2012

Hi sorry for the delay. I'll look at this very soon!

tsa commented on d48e9ff Nov 2, 2012

Could you replace usage of "typename" with "class"... just to fit in with the rest of the code.

tsa commented on 950da8d Nov 2, 2012

You've re-indented a bunch of my code. Please could we keep this patch to one issue. If you wish to reformat my code to 2 spaces then you can open a separate pull request for that, changing the format of the entire project.


tsa commented Nov 2, 2012

Hi, please see my comments on the individual commits. I will re-review after you've fixed those issues. You won't have to wait so long sorry about the delay!

hammonda commented Nov 3, 2012

Sorry about the reformatting ...


tsa commented Nov 5, 2012

No problem, you can reformat with a second patch if you want I also prefer 2 characters now!

David Hammond notifications@github.com wrote:

Sorry about the reformatting ...

Reply to this email directly or view it on GitHub:
#13 (comment)

Sent from my Android phone with K-9 Mail. Please excuse my brevity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment