-
Notifications
You must be signed in to change notification settings - Fork 29
fix: not logging auth part of repo url #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tschaub could you please merge this, it's a security vulnerability, many modules using |
|
Would also love to see this merged <3 |
tschaub
added a commit
that referenced
this pull request
Feb 14, 2015
fix: not logging auth part of repo url
|
👍 Thank you :) |
ChALkeR
added a commit
to ChALkeR/retire.js
that referenced
this pull request
Mar 23, 2018
ChALkeR
added a commit
to ChALkeR/security-wg
that referenced
this pull request
Mar 23, 2018
eoftedal
pushed a commit
to RetireJS/retire.js
that referenced
this pull request
Mar 24, 2018
vdeturckheim
pushed a commit
to nodejs/security-wg
that referenced
this pull request
Mar 26, 2018
AdamBarah
added a commit
to AdamBarah/retire.js
that referenced
this pull request
Jul 15, 2022
patrickm68
added a commit
to patrickm68/security-wg-process
that referenced
this pull request
Sep 14, 2023
mattstern31
added a commit
to mattstern31/security-wg-process
that referenced
this pull request
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have a workflow where this module runs on e.g. Travis, with publicly available logs, auth info is compromised.