Skip to content

fix: not logging auth part of repo url #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2015
Merged

fix: not logging auth part of repo url #41

merged 1 commit into from
Feb 14, 2015

Conversation

boennemann
Copy link
Contributor

If you have a workflow where this module runs on e.g. Travis, with publicly available logs, auth info is compromised.

@gr2m
Copy link

gr2m commented Feb 1, 2015

@tschaub could you please merge this, it's a security vulnerability, many modules using grunt-gh-pages might be affected.

@janl
Copy link

janl commented Feb 11, 2015

Would also love to see this merged <3

tschaub added a commit that referenced this pull request Feb 14, 2015
fix: not logging auth part of repo url
@tschaub tschaub merged commit 2d277e3 into tschaub:master Feb 14, 2015
@boennemann boennemann deleted the fix-url branch February 14, 2015 13:55
@boennemann
Copy link
Contributor Author

👍 Thank you :)

ChALkeR added a commit to ChALkeR/retire.js that referenced this pull request Mar 23, 2018
ChALkeR added a commit to ChALkeR/security-wg that referenced this pull request Mar 23, 2018
eoftedal pushed a commit to RetireJS/retire.js that referenced this pull request Mar 24, 2018
vdeturckheim pushed a commit to nodejs/security-wg that referenced this pull request Mar 26, 2018
AdamBarah added a commit to AdamBarah/retire.js that referenced this pull request Jul 15, 2022
patrickm68 added a commit to patrickm68/security-wg-process that referenced this pull request Sep 14, 2023
mattstern31 added a commit to mattstern31/security-wg-process that referenced this pull request Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants