Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace unicode with str to make it work on py3 #517

Merged
merged 1 commit into from Feb 6, 2015
Merged

Replace unicode with str to make it work on py3 #517

merged 1 commit into from Feb 6, 2015

Conversation

lorden
Copy link
Contributor

@lorden lorden commented Feb 6, 2015

Seeing this in a project with python3 and DRF:

  File "users/serializers.py", line 69, in validate_facebook_token
    result = open_facebook.get('me')
  File "open_facebook/api.py", line 727, in get
    response = self.request(path, **kwargs)
  File "open_facebook/api.py", line 921, in request
    response = self._request(url, post_data)
  File "open_facebook/api.py", line 209, in _request
    logger.warn(error_format, extended_timeout, unicode(e))

@tschellenbach
Copy link
Owner

Great, thx!

tschellenbach added a commit that referenced this pull request Feb 6, 2015
@tschellenbach
Merge pull request #517 from lorden/remove-unicode
e67ddf9 
Replace unicode with str to make it work on py3
@tschellenbach tschellenbach merged commit e67ddf9 into tschellenbach:master Feb 6, 2015
@lorden
Copy link
Contributor Author

lorden commented Feb 6, 2015

Any plans for a new release soon?

@lorden lorden deleted the remove-unicode branch February 6, 2015 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lorden @tschellenbach