From cb38d394e467d989b887c06e2a3e61d558e70ffe Mon Sep 17 00:00:00 2001 From: imrishabh18 Date: Tue, 25 Nov 2025 19:24:14 +0530 Subject: [PATCH] Add better error message for when port's don't have x and y co-ordinates value --- .../getSimpleRouteJsonFromCircuitJson.ts | 15 ++++++++++++++- package.json | 2 +- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/lib/utils/autorouting/getSimpleRouteJsonFromCircuitJson.ts b/lib/utils/autorouting/getSimpleRouteJsonFromCircuitJson.ts index 304d89afb..4b25edfe4 100644 --- a/lib/utils/autorouting/getSimpleRouteJsonFromCircuitJson.ts +++ b/lib/utils/autorouting/getSimpleRouteJsonFromCircuitJson.ts @@ -1,5 +1,4 @@ import type { CircuitJsonUtilObjects } from "@tscircuit/circuit-json-util" -import type { Trace } from "lib/components" import type { SimpleRouteConnection } from "./SimpleRouteJson" import type { SimpleRouteJson } from "./SimpleRouteJson" import type { AnyCircuitElement } from "circuit-json" @@ -157,6 +156,20 @@ export const getSimpleRouteJsonFromCircuitJson = ({ // TODO handle trace.connected_source_net_ids const [portA, portB] = connectedPorts + + if (portA.x === undefined || portA.y === undefined) { + console.error( + `(source_port_id: ${portA.source_port_id}) for trace ${trace.source_trace_id} does not have x/y coordinates. Skipping this trace.`, + ) + return null + } + if (portB.x === undefined || portB.y === undefined) { + console.error( + `(source_port_id: ${portB.source_port_id}) for trace ${trace.source_trace_id} does not have x/y coordinates. Skipping this trace.`, + ) + return null + } + const layerA = portA.layers?.[0] ?? "top" const layerB = portB.layers?.[0] ?? "top" diff --git a/package.json b/package.json index c34f0d76d..dc9b39e9f 100644 --- a/package.json +++ b/package.json @@ -65,7 +65,7 @@ "circuit-json-to-gltf": "^0.0.31", "circuit-json-to-simple-3d": "^0.0.9", "circuit-json-to-spice": "^0.0.25", - "circuit-to-svg": "^0.0.279", + "circuit-to-svg": "^0.0.280", "concurrently": "^9.1.2", "connectivity-map": "^1.0.0", "debug": "^4.3.6",