From d97f764890b546d1325afba4bd309ad6a6ae7306 Mon Sep 17 00:00:00 2001 From: Ayush Jhawar Date: Wed, 26 Nov 2025 21:28:06 +0530 Subject: [PATCH 1/4] =?UTF-8?q?Update=20NormalComponent=20and=20CadModel?= =?UTF-8?q?=20to=20pass=20=20showAsTranslucentModel=20=20=E2=86=92=20=20sh?= =?UTF-8?q?ow=5Fas=5Ftranslucent=5Fmodel?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../base-components/NormalComponent/NormalComponent.ts | 1 + lib/components/primitive-components/CadModel.ts | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/components/base-components/NormalComponent/NormalComponent.ts b/lib/components/base-components/NormalComponent/NormalComponent.ts index 15d809536..60a8e3aa9 100644 --- a/lib/components/base-components/NormalComponent/NormalComponent.ts +++ b/lib/components/base-components/NormalComponent/NormalComponent.ts @@ -1424,6 +1424,7 @@ export class NormalComponent< footprinter_string: typeof footprint === "string" && !cadModel ? footprint : undefined, + show_as_translucent_model: this.props.showAsTranslucentModel, } as any) this.cad_component_id = cad_model.cad_component_id } diff --git a/lib/components/primitive-components/CadModel.ts b/lib/components/primitive-components/CadModel.ts index 353cf3203..171d3aa63 100644 --- a/lib/components/primitive-components/CadModel.ts +++ b/lib/components/primitive-components/CadModel.ts @@ -112,6 +112,7 @@ export class CadModel extends PrimitiveComponent { typeof props.modelUnitToMmScale === "number" ? props.modelUnitToMmScale : undefined, + show_as_translucent_model: parent.props.showAsTranslucentModel, ...urlProps, } as any) From 8cc3021f22042434bd285623f48dfecef9f0d72f Mon Sep 17 00:00:00 2001 From: Ayush Jhawar Date: Fri, 28 Nov 2025 20:53:00 +0530 Subject: [PATCH 2/4] Fix tests --- .../group-rotation-for-cad-component.test.tsx | 1 + .../primitive-components/led-color-for-cad-component.test.tsx | 1 + 2 files changed, 2 insertions(+) diff --git a/tests/components/primitive-components/group-rotation-for-cad-component.test.tsx b/tests/components/primitive-components/group-rotation-for-cad-component.test.tsx index 5b545cc72..e8e82eed9 100644 --- a/tests/components/primitive-components/group-rotation-for-cad-component.test.tsx +++ b/tests/components/primitive-components/group-rotation-for-cad-component.test.tsx @@ -43,6 +43,7 @@ test("group rotation on the cad model", async () => { "y": 0, "z": 45, }, + "show_as_translucent_model": undefined, "source_component_id": "source_component_0", "type": "cad_component", } diff --git a/tests/components/primitive-components/led-color-for-cad-component.test.tsx b/tests/components/primitive-components/led-color-for-cad-component.test.tsx index e5c5e63ba..b488a639a 100644 --- a/tests/components/primitive-components/led-color-for-cad-component.test.tsx +++ b/tests/components/primitive-components/led-color-for-cad-component.test.tsx @@ -37,6 +37,7 @@ test("color for cad model", async () => { "y": 0, "z": 0, }, + "show_as_translucent_model": undefined, "source_component_id": "source_component_0", "type": "cad_component", } From a5782b0a2dc6bf6f51c37cf1c7063f1a442101b7 Mon Sep 17 00:00:00 2001 From: Ayush Jhawar <111112495+Ayushjhawar8@users.noreply.github.com> Date: Fri, 28 Nov 2025 21:10:13 +0530 Subject: [PATCH 3/4] Update lib/components/base-components/NormalComponent/NormalComponent.ts Co-authored-by: Rishabh Gupta <38923768+imrishabh18@users.noreply.github.com> --- .../base-components/NormalComponent/NormalComponent.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/components/base-components/NormalComponent/NormalComponent.ts b/lib/components/base-components/NormalComponent/NormalComponent.ts index 60a8e3aa9..e24a39187 100644 --- a/lib/components/base-components/NormalComponent/NormalComponent.ts +++ b/lib/components/base-components/NormalComponent/NormalComponent.ts @@ -1424,7 +1424,7 @@ export class NormalComponent< footprinter_string: typeof footprint === "string" && !cadModel ? footprint : undefined, - show_as_translucent_model: this.props.showAsTranslucentModel, + show_as_translucent_model: this._parsedProps.showAsTranslucentModel, } as any) this.cad_component_id = cad_model.cad_component_id } From 806df2cba3373ae69d4dd33d8ef20919e052ad3b Mon Sep 17 00:00:00 2001 From: Ayush Jhawar Date: Fri, 28 Nov 2025 21:31:35 +0530 Subject: [PATCH 4/4] use _parsedProps --- lib/components/primitive-components/CadModel.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/components/primitive-components/CadModel.ts b/lib/components/primitive-components/CadModel.ts index 171d3aa63..e8b939bac 100644 --- a/lib/components/primitive-components/CadModel.ts +++ b/lib/components/primitive-components/CadModel.ts @@ -112,7 +112,7 @@ export class CadModel extends PrimitiveComponent { typeof props.modelUnitToMmScale === "number" ? props.modelUnitToMmScale : undefined, - show_as_translucent_model: parent.props.showAsTranslucentModel, + show_as_translucent_model: parent._parsedProps.showAsTranslucentModel, ...urlProps, } as any)