return boolean for is_mobile_request? #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
any update on this PR or travis build failure? |
|
Thanks for the comment, I apologize for the failed test :person_frowning:. I've updated, and tests now pass while also working on a live app. |
tscolari
added a commit
that referenced
this pull request
Sep 5, 2013
return boolean for is_mobile_request?
|
I'm going to dump the version soon :) Thank you for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I'm using Rails 4 with Ruby 2.0.0, and the helper method
is_mobile_request?is returning the result ofrequest.user_agent.to_s.downcase =~ @@mobylette_options[:mobile_user_agents].call. When the user agent doesn't match, the method returnsnil. When the user agent is mobile, it returns the match in:mobile_user_agents(for iphone, this is 13).Because of this, mobylette was not correctly rendering mobile templates. After this change, everything is working well.