Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Change 'new node.tcp.Connection' to 'node.tcp.createConnection'
  • Loading branch information
ry committed Jun 30, 2009
1 parent d56552d commit 8047b91
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 17 deletions.
6 changes: 6 additions & 0 deletions src/node.js
Expand Up @@ -11,6 +11,12 @@ node.createProcess = function (command) {
return process;
};

node.tcp.createConnection = function (port, host) {
var connection = new node.tcp.Connection();
connection.connect(port, host);
return connection;
};

// Timers

function setTimeout (callback, after) {
Expand Down
6 changes: 3 additions & 3 deletions test/mjsunit/test-http-server.js
Expand Up @@ -33,8 +33,10 @@ function onLoad() {

}).listen(port);

var c = new node.tcp.Connection();
var c = node.tcp.createConnection(port);

c.setEncoding("utf8");

c.addListener("connect", function () {
c.send( "GET /hello HTTP/1.1\r\n\r\n" );
requests_sent += 1;
Expand All @@ -58,8 +60,6 @@ function onLoad() {
c.addListener("disconnect", function () {
assertEquals(c.readyState, "closed");
});

c.connect(port);
}

function onExit () {
Expand Down
7 changes: 4 additions & 3 deletions test/mjsunit/test-reconnecting-socket.js
Expand Up @@ -22,10 +22,13 @@ function onLoad () {
});
});
server.listen(port);
var client = new node.tcp.Connection();

var client = node.tcp.createConnection(port);

client.setEncoding("UTF8");

client.addListener("connect", function () {
puts("client connected.");
});

client.addListener("receive", function (chunk) {
Expand All @@ -41,8 +44,6 @@ function onLoad () {
else
server.close();
});

client.connect(port);
}

function onExit () {
Expand Down
6 changes: 1 addition & 5 deletions test/mjsunit/test-tcp-pingpong.js
Expand Up @@ -40,8 +40,7 @@ function pingPongTest (port, host, on_complete) {
});
server.listen(port, host);

var client = new node.tcp.Connection();
assertEquals("closed", client.readyState);
var client = node.tcp.createConnection(port, host);

client.setEncoding("utf8");

Expand Down Expand Up @@ -76,9 +75,6 @@ function pingPongTest (port, host, on_complete) {
if (on_complete) on_complete();
tests_run += 1;
});

assertEquals("closed", client.readyState);
client.connect(port, host);
}

function onLoad () {
Expand Down
9 changes: 3 additions & 6 deletions website/api.txt
Expand Up @@ -952,12 +952,9 @@ socket for +node.tcp.Server+.
(TODO: access error codes.)
|=========================================================

+new node.tcp.Connection()+::
Creates a new connection object.


+connection.connect(port, host="127.0.0.1")+::
Opens a connection to the specified +port+ and
+node.tcp.createConnection(port, host="127.0.0.1")+::
Creates a new connection object and
opens a connection to the specified +port+ and
+host+. If the second parameter is omitted, localhost is
assumed.

Expand Down

0 comments on commit 8047b91

Please sign in to comment.