Permalink
Browse files

build: always compile with large file support

Fixes a nasty sizeof(struct stat) mismatch bug that caused random crashes and
silent memory corruption.
  • Loading branch information...
1 parent eda1538 commit bbd976b8c4f82d22dc3f6bc5075aeaf26f8b6fa9 @bnoordhuis bnoordhuis committed Nov 30, 2011
Showing with 5 additions and 8 deletions.
  1. +5 −1 common.gypi
  2. +0 −5 deps/uv/uv.gyp
  3. +0 −2 node.gyp
View
@@ -109,6 +109,11 @@
'BUILDING_V8_SHARED=1',
'BUILDING_UV_SHARED=1',
],
+ }, {
+ 'defines': [
+ '_LARGEFILE_SOURCE',
+ '_FILE_OFFSET_BITS=64',
+ ],
}],
[ 'OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="solaris"', {
'cflags': [ '-Wall', '-pthread', ],
@@ -128,7 +133,6 @@
],
}],
['OS=="mac"', {
- 'defines': ['__DARWIN_64_BIT_INO_T=1'],
'xcode_settings': {
'ALWAYS_SEARCH_USER_PATHS': 'NO',
'GCC_CW_ASM_SYNTAX': 'NO', # No -fasm-blocks
View
@@ -3,15 +3,10 @@
'conditions': [
['OS != "win"', {
'defines': [
- '_LARGEFILE_SOURCE',
- '_FILE_OFFSET_BITS=64',
'_GNU_SOURCE',
'EIO_STACKSIZE=262144'
],
'conditions': [
- ['OS=="mac"', {
- 'defines': ['__DARWIN_64_BIT_INO_T=1'],
- }],
['OS=="solaris"', {
'cflags': ['-pthreads'],
'ldlags': ['-pthreads'],
View
@@ -124,8 +124,6 @@
'defines': [
'ARCH="<(target_arch)"',
'PLATFORM="<(OS)"',
- '_LARGEFILE_SOURCE',
- '_FILE_OFFSET_BITS=64',
],
'conditions': [

0 comments on commit bbd976b

Please sign in to comment.