Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

build: always compile with large file support

Fixes a nasty sizeof(struct stat) mismatch bug that caused random crashes and
silent memory corruption.
  • Loading branch information...
commit bbd976b8c4f82d22dc3f6bc5075aeaf26f8b6fa9 1 parent eda1538
Ben Noordhuis authored November 30, 2011
6  common.gypi
@@ -109,6 +109,11 @@
109 109
           'BUILDING_V8_SHARED=1',
110 110
           'BUILDING_UV_SHARED=1',
111 111
         ],
  112
+      }, {
  113
+        'defines': [
  114
+          '_LARGEFILE_SOURCE',
  115
+          '_FILE_OFFSET_BITS=64',
  116
+        ],
112 117
       }],
113 118
       [ 'OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="solaris"', {
114 119
         'cflags': [ '-Wall', '-pthread', ],
@@ -128,7 +133,6 @@
128 133
         ],
129 134
       }],
130 135
       ['OS=="mac"', {
131  
-        'defines': ['__DARWIN_64_BIT_INO_T=1'],
132 136
         'xcode_settings': {
133 137
           'ALWAYS_SEARCH_USER_PATHS': 'NO',
134 138
           'GCC_CW_ASM_SYNTAX': 'NO',                # No -fasm-blocks
5  deps/uv/uv.gyp
@@ -3,15 +3,10 @@
3 3
     'conditions': [
4 4
       ['OS != "win"', {
5 5
         'defines': [
6  
-          '_LARGEFILE_SOURCE',
7  
-          '_FILE_OFFSET_BITS=64',
8 6
           '_GNU_SOURCE',
9 7
           'EIO_STACKSIZE=262144'
10 8
         ],
11 9
         'conditions': [
12  
-          ['OS=="mac"', {
13  
-            'defines': ['__DARWIN_64_BIT_INO_T=1'],
14  
-          }],
15 10
           ['OS=="solaris"', {
16 11
             'cflags': ['-pthreads'],
17 12
             'ldlags': ['-pthreads'],
2  node.gyp
@@ -124,8 +124,6 @@
124 124
       'defines': [
125 125
         'ARCH="<(target_arch)"',
126 126
         'PLATFORM="<(OS)"',
127  
-        '_LARGEFILE_SOURCE',
128  
-        '_FILE_OFFSET_BITS=64',
129 127
       ],
130 128
 
131 129
       'conditions': [

0 notes on commit bbd976b

Please sign in to comment.
Something went wrong with that request. Please try again.