Commits on Sep 9, 2011
  1. unguarded fs.watchFile cache statWatchers checking fixed

    fs.watchFile code had checks for cached previously seen filepaths where the
    check was not adequately protected against property name collisions:
    
          if (statWatchers[filename]) {
    
    could have false positives if the filepath was a chained Object property
    name, e.g. 'hasOwnProperty'.  Wild-looking errors would ensue:
    
      TypeError: Object function hasOwnProperty() { [native code] } has no method 'ad
              at Object.watchFile (fs.js:646:8)
              at /node.js/node-1_fs/test/simple/test-fs-watch-file.js:101:8
    
    Fix is to use hasOwnProperty in both places cache checks are done:
    
      function inStatWatchers(filename) {
        return Object.prototype.hasOwnProperty.call(statWatchers, filename);
      }
    
        if (inStatWatchers(filename)) {
    
    Changes updates lib/fs.js and test/simple/test-fs-watch-file.js
    
    Changes since review of previous commit
    
    A more conventional implementation of the hasOwnProperty check.
    
    Removed extra console.logs
    committed Sep 8, 2011
Commits on Aug 31, 2011
Commits on Aug 30, 2011
  1. @koichik

    tls: x509 certificate subject parsing fail

    Fixes #1568.
    koichik committed Aug 26, 2011
  2. @ry

    Strip V8 -Werror

    ry committed Aug 30, 2011
  3. @isaacs
  4. @coolaj86 @bnoordhuis
  5. @bnoordhuis

    uv: upgrade to 0ba44cf

    bnoordhuis committed Aug 30, 2011
  6. @ry

    Fix Windows build

    ry committed Aug 30, 2011
  7. @ry

    Upgrade libuv to ca11711

    ry committed Aug 30, 2011
  8. @ry

    Use new uv_fs_ apis

    This will cause master to be unstable for a while as we replace existing eio
    calls with uv_fs calls.
    Igor Zinkovsky committed with ry Aug 28, 2011
  9. @ry

    upgrade libuv to a6ed175

    ry committed Aug 30, 2011
Commits on Aug 29, 2011
  1. @ry

    Upgrade V8 to 3.5.9.1

    ry committed Aug 29, 2011
  2. @ry

    Upgrade libuv to cbbb254

    Fixes #1506
    ry committed Aug 29, 2011
  3. @ry
  4. @abi @bnoordhuis

    stdio: fix typo in doc comment

    abi committed with bnoordhuis Aug 28, 2011
  5. @mikeal @ry

    Sockets should never be attached to a ClientRequest before nextTick().

    This way the API for interacting directly with the socket object is
    consistent before and after the Agent pool is exhausted.
    
    Fixes #1601.
    mikeal committed with ry Aug 28, 2011
  6. @thejh @bnoordhuis
  7. @bnoordhuis

    v8: remove unnecessary break-after-return in switch statement

    BUG=v8:1642
    
    Review URL: http://codereview.chromium.org/7781007
    
    This is a back-port of upstream r9043. Fixes build on OS X 10.5.
    jkummerow@chromium.org committed with bnoordhuis Aug 29, 2011
Commits on Aug 28, 2011
  1. @focusaurus @bnoordhuis

    test: test for issue #752

    focusaurus committed with bnoordhuis Aug 12, 2011
  2. @focusaurus @bnoordhuis
Commits on Aug 27, 2011
  1. @DrPizza @ry

    Don't load-time link against CreateSymbolicLink, it doesn't exist on …

    …Windows Server 2003.
    
    Fixes #1592.
    DrPizza committed with ry Aug 27, 2011
  2. @ry

    merge vcbuild.bat and generate_projects.bat

    Igor Zinkovsky committed with ry Aug 26, 2011
Commits on Aug 26, 2011
  1. @bnoordhuis

    Now working on 0.5.6

    bnoordhuis committed Aug 27, 2011
  2. @bnoordhuis

    Bump version to v0.5.5

    bnoordhuis committed Aug 26, 2011
  3. @bnoordhuis

    Fix typo in configure script

    bnoordhuis committed Aug 26, 2011
  4. @ry

    Fix build - due to V8 API change

    ry committed Aug 26, 2011
  5. @ry

    Merge remote branch 'origin/v0.4'

    Conflicts:
    	AUTHORS
    	ChangeLog
    	doc/api/stdio.markdown
    	doc/index.html
    	doc/template.html
    	lib/net.js
    	src/node_version.h
    	test/simple/test-child-process-customfd-bounded.js
    	test/simple/test-console-not-call-toString.js
    ry committed Aug 26, 2011
  6. @ry

    Upgrade V8 to 3.5.8

    ry committed Aug 26, 2011
  7. @ry
  8. @ry

    Fix dns_uv.lookup order

    ry committed Aug 25, 2011
  9. @bnoordhuis

    uv: upgrade to 835782a

    bnoordhuis committed Aug 26, 2011
  10. @koichik
  11. @piscisaureus

    Upgrade libuv to 39aac4a5

    piscisaureus committed Aug 26, 2011
Commits on Aug 25, 2011
  1. @bnoordhuis

    uv: upgrade to 6490c6a

    bnoordhuis committed Aug 26, 2011
  2. @TooTallNate @bnoordhuis

    util: isRegExp() should not call toString() on its argument

    An overloaded toString() method may have side effects
    so don't call it for a simple type check.
    
    Back-port of 54b409d to the v0.4 branch.
    TooTallNate committed with bnoordhuis Aug 25, 2011