Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update #1

Merged
merged 463 commits into from Jun 29, 2019

Conversation

Projects
None yet
@tsia
Copy link
Owner

commented Jun 29, 2019

No description provided.

@iMarkus

This comment has been minimized.

Copy link

commented on d590d20 Dec 13, 2018

It still leads to a warning when compiling:

/tmp/rtl_433/src/devices/bresser_5in1.c: In function ‘bresser_5in1_callback’:
/tmp/rtl_433/src/devices/bresser_5in1.c:92:31: warning: comparison of promoted ~unsigned with unsigned [-Wsign-compare]
if ((0xff ^ msg[col]) != msg[col + 13]) {

I guess this is ok?

This comment has been minimized.

Copy link
Collaborator Author

replied Dec 13, 2018

Yes it works as intended now. Perhaps I can come up with a prettier (and warning free) way to do it later.

gvanem and others added some commits Dec 14, 2018

Fix hi-res timestamps and default search paths on Win using platform …
…files (merbanan#910)

- hi-res timestamp reading on windows (cast to 64 bit before <<32)
- Default search paths regarding rtl_433 config files for Windows platform
@gvanem

This comment has been minimized.

Copy link
Contributor

commented on d6e7d30 Dec 16, 2018

Trying to port this to Windows (quite easy), I note that e.g. for a RSSI value, you print using TERM_COLOR_YELLOW. Evident from kv_color_for_key() and if (!strcmp(key, "rssi").

But the colour in the new nice screen-shot looks bright to me. So why isn't it printed using TERM_COLOR_BRIGHT_YELLOW?

Also, term_set_bg() is never used!?

Edit: This is how it looks on Windows using
rtl_433.exe -r rtl_433_tests\tests\fineoffset_wh3080\02\gfile001.data:
rtl_433-colour

Since I see no TERM_COLOR_BRIGHT_x codes, the above screen-shot looks quite dull. But if I force a FOREGROUND_INTENSITY on all foreground colours, it looks like this:
rtl_433-colour-2

This comment has been minimized.

Copy link
Collaborator Author

replied Dec 16, 2018

The screenshot is just my own term color palette (I don't like low-intensity colors on dark, your first screen shot is a good example why). It looks good on white with a default palette also.
If blue/dark is a default on windows then add the intensity bit, I don't plan to use it. BG is just there if we choose to use this later. E.g. Red BG for battery LOW would be nice I guess.

This comment has been minimized.

Copy link
Contributor

replied Dec 16, 2018

Then how will it look on other bash / *nix user who doesn't have the same palette setup?

If blue/dark is a default on windows

It's not. CMD uses black by default. The blue BG is in my 4NT-shell.
A live view of running in CMD:
rtl_433-colour-3

Edit: Note how the Temperature: xx.x C field IMHO goes a bit beyond the left-edge of _ _.

This comment has been minimized.

Copy link
Collaborator Author

replied Dec 16, 2018

I'm not too concerned with Linux colors, users usually install a color theme where all colors look ok.
You don't have to support the bright colors, just tune the current set to look ok Windows default.

zuckschwerdt added some commits Apr 10, 2019

@gvanem

This comment has been minimized.

Copy link
Contributor

commented on 9ae2db7 Apr 20, 2019

A typo in README.md: unreleated -> unrelated.

zuckschwerdt and others added some commits Apr 21, 2019

CMake: Switch back to _GNU_SOURCE (merbanan#1054)
This fixes compilation with uClibc. Otherwise strdup is undefined.
Initial attempt to add support for the fine offset wh0290 air quality…
… monitor (merbanan#1069)

* Add support for the fine offset wh0290 air quality monitor

@tsia tsia merged commit 657b4b0 into tsia:master Jun 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.