Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update #3

Merged
merged 35 commits into from May 8, 2019

Conversation

Projects
None yet
@tsia
Copy link
Owner

commented May 8, 2019

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.

remitamine and others added some commits Apr 25, 2019

@remitamine

This comment has been minimized.

Copy link
Collaborator

commented on .github/ISSUE_TEMPLATE/4_bug_report.md in 6f366ef Apr 27, 2019

I think it would be better to link directly to bugs section here.

@remitamine

This comment has been minimized.

Copy link
Collaborator

commented on 6f366ef Apr 27, 2019

thanks, with making the instructions as comments, it will really help make the final report more readable.
I hope with these changes that will further reduce the number of invalid and incomplete issues.

rryanq and others added some commits Apr 22, 2019

[youtube] Extract additional meta data from video description on yout…
…ube music videos

YouTube music videos often have auto-generated video descriptions that can be
utilized to extract additional information about the video. This is desirable
in order to provide the user with as much meta data as possible. This commit
adds extraction methods for the following fields for youtube music videos:
- artist (fallback extraction methods added)
- track (fallback extraction methods added)
- album (new in this commit)
- release_date (new in this commit)
- release_year (new in this commit)

4 tests have been added to test this new functionality:
- YoutubeIE tests 27, 28, 29, and 30

Resolves: ytdl-org#20599
[youtube] Improve extraction robustness
Fail on missing token only when no formats found
[youtube] Remove info el for get_video_info request
Since it does not work for quite a long time
[ChangeLog] Actualize
[ci skip]
@ealgase

This comment has been minimized.

Copy link
Contributor

commented on 54f3b61 Apr 30, 2019

C'mon, Openload. Seriously?

dstftw and others added some commits May 1, 2019

@tsia tsia merged commit 80af001 into tsia:master May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.