From 7d564ee5a8fbc2ef5afb469e00ff23fd8abd4f36 Mon Sep 17 00:00:00 2001 From: Dinesh Reddy Date: Wed, 29 Oct 2025 03:13:18 -0700 Subject: [PATCH 1/2] =?UTF-8?q?Fix=20for=20ggml=20posix=20build=20error.?= =?UTF-8?q?=201.Disabled=20AMX=20(Advanced=20Matrix=20Extensions):=20-mno-?= =?UTF-8?q?amx-tile=20-mno-amx-int8=20-mno-amx-bf16=20=E2=86=92=20Don't=20?= =?UTF-8?q?use=20AMX=20instructions=20-mno-avx512bf16=20=E2=86=92=20Don't?= =?UTF-8?q?=20use=20AVX512-BF16=20instructions=20-mno-avxvnni=20=E2=86=92?= =?UTF-8?q?=20Don't=20use=20AVX-VNNI=20instructions=202.=20CMake=20Flags?= =?UTF-8?q?=20(-DGGML=5FAMX=5FTILE=3DOFF=20-DGGML=5FAMX=5FINT8=3DOFF=20-DG?= =?UTF-8?q?GML=5FAMX=5FBF16=3DOFF=20-DGGML=5FAVX512=5FBF16=3DOFF=20-DGGML?= =?UTF-8?q?=5FAVX=5FVNNI=3DOFF).=20Control=20CMake's=20build=20configurati?= =?UTF-8?q?on=20and=20do=20two=20things:=20=20=20-Prevent=20explicit=20com?= =?UTF-8?q?piler=20flags=20=20=20-Prevent=20preprocessor=20defines=20which?= =?UTF-8?q?=20enables=20AMX-specific=20code=20paths=20in=20the=20source=20?= =?UTF-8?q?code?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Dinesh Reddy --- tsi-pkg-build.sh | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tsi-pkg-build.sh b/tsi-pkg-build.sh index 511f9218de5aa..756811fad1e7f 100755 --- a/tsi-pkg-build.sh +++ b/tsi-pkg-build.sh @@ -38,13 +38,14 @@ cd ../../ echo 'building llama.cp, ggml for tsavorite and other binary for posix' if [ "$(echo "$1" | tr '[:upper:]' '[:lower:]')" = "release" ]; then - cmake -B build-posix -DGGML_TSAVORITE=ON -DGGML_TSAVORITE_TARGET=posix -DCMAKE_C_FLAGS="-DGGML_PERF_RELEASE -DGGML_TARGET_POSIX -DGGML_TSAVORITE" -DCMAKE_CXX_FLAGS="-DGGML_PERF_RELEASE -DGGML_TARGET_POSIX -DGGML_TSAVORITE" + cmake -B build-posix -DGGML_TSAVORITE=ON -DGGML_TSAVORITE_TARGET=posix -DGGML_NATIVE=ON -DGGML_AMX_TILE=OFF -DGGML_AMX_INT8=OFF -DGGML_AMX_BF16=OFF -DGGML_AVX512_BF16=OFF -DGGML_AVX_VNNI=OFF -DCMAKE_C_FLAGS="-DGGML_PERF_RELEASE -DGGML_TARGET_POSIX -DGGML_TSAVORITE -mno-amx-tile -mno-amx-int8 -mno-amx-bf16 -mno-avx512bf16 -mno-avxvnni" -DCMAKE_CXX_FLAGS="-DGGML_PERF_RELEASE -DGGML_TARGET_POSIX -DGGML_TSAVORITE -mno-amx-tile -mno-amx-int8 -mno-amx-bf16 -mno-avx512bf16 -mno-avxvnni" elif [ "$(echo "$1" | tr '[:upper:]' '[:lower:]')" = "debug" ]; then - cmake -B build-posix -DGGML_TSAVORITE=ON -DGGML_TSAVORITE_TARGET=posix -DCMAKE_C_FLAGS="-DGGML_PERF_DETAIL -DGGML_TARGET_POSIX -DGGML_TSAVORITE" -DCMAKE_CXX_FLAGS="-DGGML_PERF_DETAIL -DGGML_TARGET_POSIX -DGGML_TSAVORITE" + cmake -B build-posix -DGGML_TSAVORITE=ON -DGGML_TSAVORITE_TARGET=posix -DGGML_NATIVE=ON -DGGML_AMX_TILE=OFF -DGGML_AMX_INT8=OFF -DGGML_AMX_BF16=OFF -DGGML_AVX512_BF16=OFF -DGGML_AVX_VNNI=OFF -DCMAKE_C_FLAGS="-DGGML_PERF_DETAIL -DGGML_TARGET_POSIX -DGGML_TSAVORITE -mno-amx-tile -mno-amx-int8 -mno-amx-bf16 -mno-avx512bf16 -mno-avxvnni" -DCMAKE_CXX_FLAGS="-DGGML_PERF_DETAIL -DGGML_TARGET_POSIX -DGGML_TSAVORITE -mno-amx-tile -mno-amx-int8 -mno-amx-bf16 -mno-avx512bf16 -mno-avxvnni" else - cmake -B build-posix -DGGML_TSAVORITE=ON -DGGML_TSAVORITE_TARGET=posix -DCMAKE_C_FLAGS="-DGGML_PERF -DGGML_TARGET_POSIX -DGGML_TSAVORITE" -DCMAKE_CXX_FLAGS="-DGGML_PERF -DGGML_TARGET_POSIX -DGGML_TSAVORITE" + cmake -B build-posix -DGGML_TSAVORITE=ON -DGGML_TSAVORITE_TARGET=posix -DGGML_NATIVE=ON -DGGML_AMX_TILE=OFF -DGGML_AMX_INT8=OFF -DGGML_AMX_BF16=OFF -DGGML_AVX512_BF16=OFF -DGGML_AVX_VNNI=OFF -DCMAKE_C_FLAGS="-DGGML_PERF -DGGML_TARGET_POSIX -DGGML_TSAVORITE -mno-amx-tile -mno-amx-int8 -mno-amx-bf16 -mno-avx512bf16 -mno-avxvnni" -DCMAKE_CXX_FLAGS="-DGGML_PERF -DGGML_TARGET_POSIX -DGGML_TSAVORITE -mno-amx-tile -mno-amx-int8 -mno-amx-bf16 -mno-avx512bf16 -mno-avxvnni" fi + cmake --build build-posix --config Release # Fix GLIBC compatibility for TSI binaries From a47f44b12b3baa6775ee2bd8d79a67b23aa4fa91 Mon Sep 17 00:00:00 2001 From: Dinesh Reddy Date: Wed, 29 Oct 2025 04:13:12 -0700 Subject: [PATCH 2/2] In Posix while running models OPU profiling results are printing twice. Second call to print profiling results (in tsi_cleanup()) has been commented out. Signed-off-by: Dinesh Reddy --- ggml/src/ggml-tsavorite/ggml-tsavorite.cpp | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/ggml/src/ggml-tsavorite/ggml-tsavorite.cpp b/ggml/src/ggml-tsavorite/ggml-tsavorite.cpp index bf24888eb0cc8..7d0d0321cea9e 100644 --- a/ggml/src/ggml-tsavorite/ggml-tsavorite.cpp +++ b/ggml/src/ggml-tsavorite/ggml-tsavorite.cpp @@ -741,10 +741,11 @@ tsi_cleanup() { tsi_finalize(); GGML_TSAVORITE_LOG_INFO("Start %s\n", __func__); tsirt::utils::TSIProfiler::finalize(); - std::cout << "\nOPU Profiling Results:" << std::endl; - std::cout << tsirt::utils::TSIProfiler::getFormattedResults( - /*truncateFuncNames*/ true) - << std::endl; + // Profiling results already printed during first cleanup + // std::cout << "\nOPU Profiling Results:" << std::endl; + // std::cout << tsirt::utils::TSIProfiler::getFormattedResults( + // /*truncateFuncNames*/ true) + // << std::endl; sleep(2); GGML_TSAVORITE_LOG_INFO("End %s\n", __func__); return;